808835 - Add l10n.ini file for Chatzilla

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Ian Neal]

Attachment: Add l10n.ini

To make it easier for localisers it would be good to add an l10n.ini file to Chatzilla

Comment 1

[Ian Neal]

Comment on attachment 678522 [details] [diff] [review]
Add l10n.ini

This appears to be the correct syntax for the file and works when tested against en-GB locale. Requesting feedback to confirm.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 678522 [details] [diff] [review]
Add l10n.ini

Review of attachment 678522 [details] [diff] [review]:
-----------------------------------------------------------------

I think we'd want to mimic what I did for mobile back in the days when it had the similar structure. The file's still there at https://hg.mozilla.org/mobile-browser/file/8167d57cab8e/locales/l10n.ini

Comment 3

[Ian Neal]

Attachment: Add l10n.ini with source-depth and tld

Changes since last version:
* Added source-depth and tld parameters

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 728762 [details] [diff] [review]
Add l10n.ini with source-depth and tld

Review of attachment 728762 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this does exactly what you're hoping for? The dirs line looks like it's not doing what mobile did, but I can't remember why I kept both dirs and tld around at the time. bug 504819 wasn't helpful to reverse engineer, either.

Do you need that line? If so, for what?

::: locales/l10n.ini
@@ +3,5 @@
> +source-depth = ..
> +all = locales/all-locales
> +
> +[compare]
> +dirs = irc

I think this line shouldn't be here, or be extensions/irc.

Comment 5

[Ian Neal]

I'm using compare-locales in the following way:
compare-locales comm-aurora/mozilla/extensions/irc/locales/l10n.ini . en-GB

You appear to be able to put any random stuff into the source-depth line if you have either tld or dirs present and no includes. If you have a tld then that seems to override the dirs option.
Would you be okay with just, depth, all and dirs options?

Comment 6

[Axel Hecht [:Pike]]

source-depth is used in the dashboard code only, it's used when you're using repositories as laid out on hg.m.o and not as they're used during the build.

I think depth=../../.., dirs=extensions/irc, and all should work locally.

Comment 7

[Ian Neal]

Attachment: Just depth, all and dirs

Just using depth, all and dirs

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 742848 [details] [diff] [review]
Just depth, all and dirs

Review of attachment 742848 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this should work, but the path for all-locales needs a tweak.

::: locales/l10n.ini
@@ +1,3 @@
> +[general]
> +depth = ../../..
> +all = locales/all-locales

this should also be extensions/irc/locales/all-locales

Comment 9

[Ian Neal]

Attachment: Add l10n.ini to chatzilla [Checked in to trunk and SEA2_19_RELBRANCH repos]

Carrying forward f+ and requesting review.

Comment 10

[James Ross]

Comment on attachment 748927 [details] [diff] [review]
Add l10n.ini to chatzilla [Checked in to trunk and SEA2_19_RELBRANCH repos]

I don't know anything about the l10n.ini files so I trust someone who does has checked this.

Comment 11

[Ian Neal]

Comment on attachment 748927 [details] [diff] [review]
Add l10n.ini to chatzilla [Checked in to trunk and SEA2_19_RELBRANCH repos]

http://hg.mozilla.org/chatzilla/rev/359ba8d16b20
http://hg.mozilla.org/chatzilla/rev/c5625e81524b