Closed
Bug 808841
Opened 12 years ago
Closed 12 years ago
Implement AudioContext.listener
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
12.11 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Need this as the first step in the support for positional audio.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 678562 [details] [diff] [review]
Patch (v1)
>+ NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NATIVE_PTR(tmp->mListener, AudioListener, "listener")
Why can't we TRAVERSE_NSCOMPTR here? Because it's not nsISupports? Might be worth a comment.
r=me
Attachment #678562 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Yes, I'll add a comment.
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
Assignee | |
Comment 5•12 years ago
|
||
Oops, forgot to add ThreeDPoint.h. Added it here: https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d4ccf671dd
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f54fd962cf87
https://hg.mozilla.org/mozilla-central/rev/b4d4ccf671dd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
Assignee | |
Comment 7•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•