808892 - [Settings] More Information for Firmware, Software

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[David Scravaglieri [:scravag]]

As a user I want to be able to click on "More Information" button on Device Information, so that I can see detailed info on Firmware, Hardware and MAC address.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Could you give a example for Firmware and Hardware?

and Mac address is available in Settings -> Wi-Fi -> Manage Networks, Do we need to move it to Device information -> "More Information"?

Comment 2

[Alex Keybl [:akeybl]]

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

Comment 3

[Evelyn Hung]

Attachment: add placeholder in device info section

Fields need to be filled out: Software, Last Updated, and Firmware Revision.
Need clear definition and gecko support for these.

Comment 4

[Evelyn Hung]

https://github.com/mozilla-b2g/gaia/pull/6449

Comment 6

[Evelyn Hung]

Sorry, I think I shouldn't close this bug, since it needs further discussion with OEMs to understand what exactly it is to show. and then make changes later when the information is defined more precisely.

Comment 7

[Dietrich Ayala (:dietrich)]

"Last Updated" is bug 809974.

Updating this bug's summary to reflect the remaining pieces:

* Firmware
* Software

What exactly is supposed to be there?

Can you implement it so that the placeholders are hidden if there's no value available?

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

Still need more definition on what's to be displayed especially on software / firmware version

Comment 9

[Josh Carpenter [:jcarpenter]]

"Software" field should display OS name and version. eg: "FirefoxOS 1.0.0"

That information is also listed under More Information section ("OS version: 1.0.0"). The duplication is fine.

Re: Firmware, I have no idea. It's important that Larissa added these fields as placeholders in lieu of having specific requirements. If we don't get firmware information, we can just remove the field. Per her 11/14 feedback to the "Web API for device information" email thread:

> I agree with what Josh wrote in his previous email. I added those
> fields as placeholders (as clearly stated in the wireframe) because
> I didn't have concrete requirements about what we wanted to include.
> As a guideline for what entries we should and shouldn't display:

Comment 10

[Josh Carpenter [:jcarpenter]]

(In reply to Josh Carpenter [:jcarpenter] from comment #9)
> . . .It's important that Larissa added these fields. . .

Meant to say: "important to remember..."

Comment 11

[Kai-Chih Hu [:khu]]

Hi, Chris, do you agree to remove "firmware version" here?

Comment 12

[Dietrich Ayala (:dietrich)]

Per the OEM email thread, we will need to have firmware field visible for some OEMs.

We need an answer from Evelyn to my question in comment #7: Can you implement so that the firmware field is visible if the value is present, and not visible if the value is empty?

That would allow us the flexibility to show/hide the field on a per-configuration basis.

Comment 13

[Larissa Co [:lco]]

Just checked on the device, the location of the content look about right. 

One thing to bring up: some of these strings are extremely long, and I don't think it's a good idea to right-align the values with the header. Can't we use two lines instead (ala settings list with a few font tweaks)? If not for v.1, for v.soon?

Comment 14

[Kai-Chih Hu [:khu]]

Let me talk with OEMs to make sure if they can provide such information. 
Meanwhile, we need to make sure where to save firmware version.

Comment 15

[Dietrich Ayala (:dietrich)]

Kevin, I still have not received an answer to comment #7 and comment #12.

Evelyn, if you can implement the field to show or hide based on the presence of firmware version, we can close this bug.

Can you please provide an answer to implementing it this way?

Comment 16

[Kai-Chih Hu [:khu]]

Hi, Dietrich, so, if we hide this field, did you mean, we won't want this in v1? 
If we agree to remove this from v1, that would be great to hide this field. :)

Comment 17

[Dietrich Ayala (:dietrich)]

No, that is not what I am asking.

I am asking if Evelyn can implement the field so that *if* a firmware version is available, the field is shown. *If* there is no firmware version available, the field is not shown.

That way, we can accommodate *all* OEMs preferences about firmware version display, and customize the build accordingly, and close this bug.

Comment 18

[Chris Lee [:clee]]

Comment 17 is likely the best path forward here.

Comment 19

[Evelyn Hung]

Dietrich, yes I can implement that. But since the setting assignment is globally applied on all fields, so some fields that lack of a value in mozSettings DB will also be hidden. Or, I could make this a special case that only check this field and note due to the comments here.

On the other hand, if we want to support adding firmware version from OEM, that will need Gecko support to design a way for setting the value into mozSettings DB when making a build.

Comment 20

[Evelyn Hung]

and I'm waiting for bug 809974 for "Last Updated" field. :'(

Comment 21

[Evelyn Hung]

Oh, please ignore comment 20, I realized "Last Updated" field is another issue and won't block this.

Comment 22

[Dietrich Ayala (:dietrich)]

(In reply to Evelyn Hung [:evelyn] from comment #19)
> Or, I could make this a special case
> that only check this field and note due to the comments here.

This is fine for V1. We can develop the perfect approach in a subsequent release.

Comment 23

[Kai-Chih Hu [:khu]]

Evelyn will hide this field. ETA = Today. 
We should also create another bug to Gecko engineer to provide a method for OEM to save such information into Firefox OS.

Comment 24

[Kai-Chih Hu [:khu]]

Bug 816899 is created.

Comment 25

[Evelyn Hung]

I think I need one more day to address Larissa's comment 13 and wait reviewer's feedback.

Comment 26

[Evelyn Hung]

Attachment: hide firmware field if the value is not defined

also add software version value that is OS name + OS version
(although the software version needs to be added into Settings
DB from Gecko side, not hard code here)
als fix MAC address is missing because of lazy-loading wifi panel

Comment 28

[Evelyn Hung]

Comment on attachment 687433 [details]
hide firmware field if the value is not defined

I've addressed review comments from vivien, re-assign him as my reviewer for verifying.

Comment 29

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 687433 [details]
hide firmware field if the value is not defined

Tim review is enough as long as you have fixed my comment :)

Comment 30

[Evelyn Hung]

https://github.com/mozilla-b2g/gaia/pull/6771