816899 - Provide a method for OEM to save firmware version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Kai-Chih Hu [:khu]]

Continue from bug 808892. 

We need to make sure we have a way for OEM to give their firmware version and save into Firefox OS. 

Additional question(s): 
1. Should we also need a way for OEM to "update" the firmware version? And how?

Comment 1

[Kai-Chih Hu [:khu]]

Marco, any comments?

Comment 2

[Marco Chen [:mchen]]

Normally, the build information is put on Android property (ex: ro.build.XXX).
And the properties can be updated from kernel or init.XXX.rc (boot.img) as well as the build.prop (system.img). 
So OEM can update related info into these files by itself.

What we need to do is just to "read" them back and make sure the correct property name with OEM.

Comment 3

[Evelyn Hung]

So please use this key "deviceinfo.firmware_revision" to write into mozSettings DB. Thanks.

Comment 4

[Evelyn Hung]

Please also add 'deviceinfo.software' which should be OS name + OS version. eg: "FirefoxOS 1.0.0" (UX confirmed, see comment 9 in bug 808892). Thanks!

Please note this issue is intended for a Gecko patch, although it's related to Settings app.

Comment 5

[Shelly Lin [:shelly]]

Attachment: v1: Add firware revision and software info

Hi Chris, in this patch, I've added keys of firmware revision and software info to the IndexedDB, just like what I did in bug 790158. I've cleaned up some coding style issue from my previous patch as well (if that's okay).

Could you give my some feedback? Thanks a lot.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 687614 [details] [diff] [review]
v1: Add firware revision and software info

This seems fine, but we can't use the name "Firefox" in unbranded assets.  Let's go with "Boot2Gecko" for now.

Comment 7

[Shelly Lin [:shelly]]

Attachment: v1: Add firware revision and software info, clean up.

Thanks Chris, I've changed the OS name from FirefoxOS to Boot2Gecko.

Here's the try server result:
https://tbpl.mozilla.org/?tree=Try&rev=d1ac572b1342
(The Bi of B2G otoro opt doesn't seem related)
https://tbpl.mozilla.org/?tree=Try&rev=d81d1fb4ccb3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75ae0108f7f3

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/75ae0108f7f3

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d6239ba4d40f
https://hg.mozilla.org/releases/mozilla-b2g18/rev/7a4db80cc3a8