Closed Bug 816899 Opened 7 years ago Closed 7 years ago
Provide a method for OEM to save firmware version
Continue from bug 808892. We need to make sure we have a way for OEM to give their firmware version and save into Firefox OS. Additional question(s): 1. Should we also need a way for OEM to "update" the firmware version? And how?
Marco, any comments?
blocking-basecamp: --- → ?
Normally, the build information is put on Android property (ex: ro.build.XXX). And the properties can be updated from kernel or init.XXX.rc (boot.img) as well as the build.prop (system.img). So OEM can update related info into these files by itself. What we need to do is just to "read" them back and make sure the correct property name with OEM.
So please use this key "deviceinfo.firmware_revision" to write into mozSettings DB. Thanks.
Please also add 'deviceinfo.software' which should be OS name + OS version. eg: "FirefoxOS 1.0.0" (UX confirmed, see comment 9 in bug 808892). Thanks! Please note this issue is intended for a Gecko patch, although it's related to Settings app.
Hi Chris, in this patch, I've added keys of firmware revision and software info to the IndexedDB, just like what I did in bug 790158. I've cleaned up some coding style issue from my previous patch as well (if that's okay). Could you give my some feedback? Thanks a lot.
Attachment #687614 - Flags: feedback?(jones.chris.g)
Comment on attachment 687614 [details] [diff] [review] v1: Add firware revision and software info This seems fine, but we can't use the name "Firefox" in unbranded assets. Let's go with "Boot2Gecko" for now.
Attachment #687614 - Flags: feedback?(jones.chris.g) → feedback+
Thanks Chris, I've changed the OS name from FirefoxOS to Boot2Gecko. Here's the try server result: https://tbpl.mozilla.org/?tree=Try&rev=d1ac572b1342 (The Bi of B2G otoro opt doesn't seem related) https://tbpl.mozilla.org/?tree=Try&rev=d81d1fb4ccb3
Attachment #688075 - Flags: review?(jones.chris.g) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.