Closed Bug 809219 Opened 9 years ago Closed 9 years ago

[WebPayment] mozPay unit tests

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22
Tracking Status
firefox20 --- wontfix
firefox21 --- wontfix
firefox22 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → ferjmoreno
Depends on: 809218
OS: Mac OS X → All
Hardware: x86 → All
Fernando - What framework are you looking at for automation? I remember when I reviewed what automation frameworks were possible, so on the QA side, I saw front-end automation being the worthwhile investment, as a good amount of this is better tested from the UI.
I am thinking about xpcshell unit tests. I will only be testing the Gecko implementation this way, not the Gaia side.
Component: General → DOM: Device Interfaces
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Blocks: 767818
No longer blocks: basecamp-payments
Attached patch WIP (obsolete) — Splinter Review
Attached patch v1Splinter Review
Not much, but it is a start.
Attachment #715181 - Attachment is obsolete: true
Attachment #715434 - Flags: review?(fabrice)
Comment on attachment 715434 [details] [diff] [review]
v1

Review of attachment 715434 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but can you add the decoded version of the jwt in comments? I think this would help understand what each test is doing.
Attachment #715434 - Flags: review?(fabrice) → review+
Thanks Fabrice! I'll do that
Comment on attachment 715434 [details] [diff] [review]
v1

Note that this patch requires Bug 809218 to also be uplifted to b2g18
Attachment #715434 - Flags: approval-mozilla-b2g18?
Comment on attachment 715434 [details] [diff] [review]
v1

Test only, approving.
Attachment #715434 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
https://hg.mozilla.org/mozilla-central/rev/944d5d9aff21
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.