809219 - [WebPayment] mozPay unit tests

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Jason Smith [:jsmith]]

Fernando - What framework are you looking at for automation? I remember when I reviewed what automation frameworks were possible, so on the QA side, I saw front-end automation being the worthwhile investment, as a good amount of this is better tested from the UI.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

I am thinking about xpcshell unit tests. I will only be testing the Gecko implementation this way, not the Gaia side.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: WIP

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Not much, but it is a start.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 715434 [details] [diff] [review]
v1

Review of attachment 715434 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but can you add the decoded version of the jwt in comments? I think this would help understand what each test is doing.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Thanks Fabrice! I'll do that

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 715434 [details] [diff] [review]
v1

Note that this patch requires Bug 809218 to also be uplifted to b2g18

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 715434 [details] [diff] [review]
v1

Test only, approving.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/944d5d9aff21

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/944d5d9aff21

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/efa1501938b3