80933 - Use NS_SUCCEEDED instead of NS_OK == result

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Jörg Brunsmann]

Instead of NS_SUCCEEDED many source files use (NS_OK == result). For example:

http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsHTMLAnchorEle
ment.cpp

NS_SUCCEEDED is defined in

http://lxr.mozilla.org/seamonkey/source/xpcom/base/nsError.h#84

as

#define NS_FAILED(_nsresult) ((_nsresult) & 0x80000000)
#define NS_SUCCEEDED(_nsresult) (!((_nsresult) & 0x80000000))
 
Compiled with NS_OK == result the size of the object file is:

16.05.01  16:48                245.269 nsHTMLAnchorElement.obj
 
Compiled with NS_SUCCEEDED the size of the object file is:

16.05.01  15:32                245.276 nsHTMLAnchorElement.obj

Either way. In order to identify which macro is better (space and
performance wise) one need to replace all NS_OK == result with 
NS_SUCCEEDED.

Comment 1

[Kathleen :Brade]

nsHTMLAnchorElement.cpp is jst... let's start there...

Comment 2

[Johnny Stenback (:jst)]

There's no question about what the macro's do, they won't change, but wether or
not using the macro in every place in this file is a different issue, and since
the current code doesn't break anything (AFAIK) I won't sepnd time looking into
this now. Future for now.

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.

Comment 4

[Boris Zbarsky [:bzbarsky]]

nsHTMLAnchorElement now uses NS_SUCCEEDED everywhere.  Marking fixed; please
file separate bugs on other instances of this.