80937 - right arrow at end of textarea crashes

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[olaf]

Pressing the right arrow key at the end of the text in a TEXTAREA sometimes
wraps the cursor around to the start of the text, but in most cases causes segfault.
Linux CVS on 20010515.

Comment 1

[Vladimir Ermakov]

I cannot reproduce on Linux RedHat 6.2 build 2001-05-15-08-trunk...

Comment 2

[Kathleen :Brade]

caused by or related to fix for #68367?

-->mjudge

Comment 3

[Johannes Almiala]

Just filed related/duplicate bug. Difference is that there is no crash. See
#81379: Cursor wraps from the end of text to the beginning in a textarea. 

Comment 4

[Johannes Almiala]

*** Bug 81379 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm seeing the wrapping (not the crash) on all textareas and in the text input in 
the bugzilla sidebar.

Comment 6

[Vladimir Ermakov]

*** Bug 80980 has been marked as a duplicate of this bug. ***

Comment 7

[rubydoo123]

setting to 9.1

Comment 8

[R.K.Aa.]

*** Bug 81721 has been marked as a duplicate of this bug. ***

Comment 9

[doctor__j]

*** Bug 81760 has been marked as a duplicate of this bug. ***

Comment 10

[Jesse Ruderman]

Crashes in gklayout.dll on windows, setting all/all.  Updating summary to cover 
two cases that seem to be covered by this bug.

Comment 11

[rubydoo123]

I can't reproduce this on win98 using the build from 2001051720

Comment 12

[sujay]

bingo!

I can reproduce this every time with these steps. very easily:

1) launch netscape
2) jump to http://bugzilla.mozilla.org
3) Enter a new bug report
4) choose product = Browser
4) click in the "Description" field
5) right arrow

CRASH!

Comment 13

[sujay]

more info:

happens even though you have text in the description.
found using 5/22 build on Win 98
only happens for Description field in New bug page
talkback report ID = 30768588

Comment 14

[Kathleen :Brade]

*** Bug 82151 has been marked as a duplicate of this bug. ***

Comment 15

[Simon Fraser [no longer active]]

It crashes in nsFrame::GetFrameFromDirection(), at 

3733:  result = lastFrame->GetNextSibling(&lastFrame);

because lastFrame is null when lineFrameCount == 4.

"it" (thanks for the descriptive name) here is a nsTableRowGroupFrame.

Comment 16

[Matthew T (active 1999-2002)]

Note that the textarea wrapping problem only happens if the text is long enough 
for the textarea to have a vertical scrollbar. It doesn't happen when the 
textarea doesn't have a scrollbar.

Comment 17

[Johannes Almiala]

Additional note to previous note by mpt: On linux, the scrollbar appears 
immediately when a single character is entered to the textarea -> a single 
character is enough to replicate this behaviour.

Comment 18

[mjudge]

got a fix

Comment 19

[mjudge]

Attachment: fix to use prefered method of getting next line sibling nsFrame.cpp

Comment 20

[mjudge]

marking fix in hand

Comment 21

[mjudge]

oops just realized i removed an assertion.  that was not necessary and I would 
like to leave it.  here is a simpler patch.

Comment 22

[mjudge]

Attachment: check for null and leave assertion

Comment 23

[kinmoz]

sr=[e-mail]

Comment 24

[Charles Manske]

r=cmanske

Comment 25

[Asa Dotzler [:asa]]

a= [e-mail] on behalf of drivers

Comment 26

[Vladimir Ermakov]

*** Bug 82589 has been marked as a duplicate of this bug. ***

Comment 27

[mjudge]

fixed

Comment 28

[R.K.Aa.]

Most of the dups here are about the wrapping. Is that fixed now?

Comment 29

[Matthew T (active 1999-2002)]

No, the wrapping isn't fixed. I reopened bug 82151 for that case, since (in all 
modesty:-) I think the steps to reproduce for that bug are the most precise of 
the various wrapping duplicates.

Comment 30

[Vladimir Ermakov]

verifying fixed on build 2001-05-31-08-trunk

Comment 31

[Leo L. Schwab]

If it got fixed, then it subsequently got un-fixed.  It's happening on build
2001112009 under Windows 98.

The conditions described earlier seem to continue to hold: Enter enough text for
the vertical scrollbar to appear, then right-arrow past the end of the textarea.
 The cursor will (usually) wrap to the beginning of the textarea.

Other neat trick you can try:  Enter more than one line of text into a text
area; leave a hanging line (unterminated with a carriage return).  Press
up-arrow until you reach the beginning (first character) of the textarea.  Press
down-arrow until you are on the last line.  Press down-arrow once more; the
cursor will move to the end of the line.  Then press right arrow; the cursor
will wrap to the beginning of the line.

Even more fun:  Enter lines of text.  Press left-arrow a few times to back up,
then press right-arrow repeatedly to move to the end of the line; the cursor
will stay there.  Now press down-arrow; on my machine, the cursor will move
backwards about one pixel.

Comment 32

[Kathleen :Brade]

Leo--please see bug 82151