Closed Bug 809550 Opened 13 years ago Closed 13 years ago

Graphics driver block request: All NVIDIA and Intel devices on all Mac OSX versions >= 10.6 for WebGL anti-aliasing

Categories

(Toolkit :: Blocklist Policy Requests, defect)

Product:
Toolkit
Component:
Blocklist Policy Requests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr10 - ---

People

(Reporter: bjacob, Assigned: jorgev)

References

Details

(Whiteboard: [gfx])

OS: Darwin 10, Darwin 11, Darwin 12 Vendor: 0x10de, 0x8086 Feature: WEBGL_MSAA Feature status: BLOCKED_DEVICE Reasons: Bug 807741 and this Chromium bug: http://code.google.com/p/chromium/issues/detail?id=137303. Has security implications, though the Chromium bug is publicly visible.
Note: a total of 6 entries should be added (3 OS values times 2 Vendor values).
It looks like the Chromium bug is no longer public.
Assignee: nobody → jorge
OK. If you would like me to add more details here for justification, I can do that but a prerequisite is to hide this bug then.
(In reply to Benoit Jacob [:bjacob] from comment #3) > OK. If you would like me to add more details here for justification, I can > do that but a prerequisite is to hide this bug then. No, it was just a comment. Blocks have been staged. IDs: 197, 199, 201, 203, 205, 207.
Keywords: qawanted
QA Contact: anthony.s.hughes
(In reply to Jorge Villalobos [:jorgev] from comment #4) > Blocks have been staged. IDs: 197, 199, 201, 203, 205, 207. Can you please specify what each of these blocks cover so I can set up the test plan?
Also, what is WebGL Anti-aliasing and how do I test if it's blocked?
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6) > Also, what is WebGL Anti-aliasing and how do I test if it's blocked? Made a testcase. If it's correcly blocked, you should see "UNAVAILABLE" and the two canvases should look identical. WebGL Antialiasing is a technique that smoothes the edges of trianges drawn by WebGL. Check antialiasing in e.g. Wikipedia.
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #5) > Can you please specify what each of these blocks cover so I can set up the > test plan? 197: 0x10de, Darwin 10 199: 0x10de, Darwin 11 201: 0x10de, Darwin 12 203: 0x8086, Darwin 10 205: 0x8086, Darwin 11 207: 0x8086, Darwin 12 Benoit can tell you what the vendor IDs correspond to and which Mac OS X versions the Darwin versions map to.
(In reply to Jorge Villalobos [:jorgev] from comment #9) > Benoit can tell you what the vendor IDs correspond to and which Mac OS X > versions the Darwin versions map to. Also do these correlate to a specific GPU and driver version?
Oh, and what versions of Firefox does this affect?
0x10de is NVIDIA 0x8086 is Intel Darwin 10 is Mac OSX 10.6 Darwin 11 is Mac OSX 10.7 Darwin 12 is Mac OSX 10.8 The bug that we want to avert here affects all NVIDIA and Intel GPUs. That's why these blocklist entries are only about the Vendor ID.
It should affect every version of Firefox since 4.
Okay, thanks. I think I have enough to get started. I'll try to get this done before the end of the week.
Jorge and Benoit, please review my testplan: https://wiki.mozilla.org/QA/Blocklisting/OSX_WebGL_AA If it's acceptable, I can have Softvision burn through it once Firefox 17.0b5 is signed off.
Reviewed the WebGL-specific part, looks good. I have no idea about the blocklisting aspects (URLs etc).
Looks good to me.
Thanks guys. I'll report back Friday with any results.
Most of the testing has been complete overall successfully. We encountered the following issues: * Mac OSX 10.8 with NVidia GeForce 9400 and Intel HD 3000 failed to block Firefox 10.0.10esr * Mac OSX 10.7 with NVidia GeForce 9400 failed to block Firefox 10.0.10esr * Mac OSX 10.6 with NVidia GeForce 9400 failed to block Firefox 10.0.10 esr * Mac OSX 10.6 with Intel GMA 950 failed to block for *all* Firefox versions * Firefox 4.0 was blocked before pinging the blocklist on all platforms (unsupported?) * We could not track down an OSX 10.5 machine with an NVidia GPU for testing Otherwise, everything else was blocked as expected. Detailed Results: https://wiki.mozilla.org/QA/Blocklisting/OSX_WebGL_AA
Keywords: qawanted
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #19) > Most of the testing has been complete overall successfully. > > We encountered the following issues: > * Mac OSX 10.8 with NVidia GeForce 9400 and Intel HD 3000 failed to block > Firefox 10.0.10esr > * Mac OSX 10.7 with NVidia GeForce 9400 failed to block Firefox 10.0.10esr > * Mac OSX 10.6 with NVidia GeForce 9400 failed to block Firefox 10.0.10 esr Indeed, Firefox 10 ESR is not able to use the downloadable blacklist on Mac OSX. If we want a fix for ESR10 we will have to make it a compiled-code blacklist change (a code change). > * Mac OSX 10.6 with Intel GMA 950 failed to block for *all* Firefox versions That is very concerning. Jorge, do you confirm that you added blacklist entries for vendor 0x8086 ? Anthony's finding that blocking works for NVIDIA but not for Intel could be explained if there were e.g. a typo in the 0x8086. > * Firefox 4.0 was blocked before pinging the blocklist on all platforms > (unsupported?) WebGL anti-aliasing was introduced in Firefox 10. Sorry I gave you a wrong information in comment 13. > * We could not track down an OSX 10.5 machine with an NVidia GPU for testing WebGL is blocked on OSX 10.5. No need to test there. > > Otherwise, everything else was blocked as expected. > > Detailed Results: > https://wiki.mozilla.org/QA/Blocklisting/OSX_WebGL_AA Thanks!
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #19) > * Mac OSX 10.6 with Intel GMA 950 failed to block for *all* Firefox versions > > Detailed Results: > https://wiki.mozilla.org/QA/Blocklisting/OSX_WebGL_AA Wait! Looking at the detailed results tells a different story about Intel: that it failed to get any WebGL antialiasing at all, NOT that it failed to block! So there is nothing to worry about here, just means that this box doesn't support antialiasing. Not too surprising for Mac 10.6 + Intel.
Yeah, you are right, sorry for making that mistake interpreting the results. So the only thing we need to worry about is whether we want ESR10 to block.
Correct. /me hopes not...
(In reply to Benoit Jacob [:bjacob] from comment #20) > > We encountered the following issues: > > * Mac OSX 10.8 with NVidia GeForce 9400 and Intel HD 3000 failed to block > > Firefox 10.0.10esr > > * Mac OSX 10.7 with NVidia GeForce 9400 failed to block Firefox 10.0.10esr > > * Mac OSX 10.6 with NVidia GeForce 9400 failed to block Firefox 10.0.10 esr > > Indeed, Firefox 10 ESR is not able to use the downloadable blacklist on Mac > OSX. Why is this the case? Is there a bug for it?
It's just that the ability to use a downloadable blacklist started as a Windows-only thing and was extended to other platforms later. If I remember correctly that was around bug 689598 which is marked mozilla11.
Okay, thanks. Are we good to go? Should I push the blocks to prod?
As far as I can see, everything looks good! The ESR10 question does not have to block going to production.
We'll discuss what to do about the ESR in bug 807741.
tracking-firefox-esr10: ? → -
Pushed to prod. IDs: 198, 200, 202, 204, 206, 208.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Thanks! It is very important indeed to keep this wiki page up to date.
Jorge, blockid 200 accidentally lists the feature blocked as featureStatus, and the feature status as the driverVersion. Can you fix that?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh, sorry for that. It's fixed now.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
I just discovered a pref called "gfx.blacklist.webgl.msaa" which was user-defined to value "4" (don't remember if it was string or int – reset it to "": empty string). Is this change what the blocklist caused, i. e. is "4" the correct value? (I'm on Mac OS X 10.8 on MBA 2012 Intel HD 4000.)
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.