Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Implement downloadable device blacklisting for Android

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: ajuma, Assigned: drs)

Tracking

Trunk
mozilla11
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

6 years ago
We currently implement a only hard-coded device blacklist in GfxInfo. We should add support for a downloadable blacklist.

Updated

6 years ago
Depends on: 668004
(Assignee)

Updated

6 years ago
Depends on: 704710
(Assignee)

Updated

6 years ago
No longer depends on: 704710
(Assignee)

Updated

6 years ago
Depends on: 704710
(Assignee)

Updated

6 years ago
Assignee: nobody → dsherk
(Assignee)

Comment 1

6 years ago
Created attachment 576656 [details] [diff] [review]
Patch v1.0, enable downloadable blacklist on Android devices.

Setting reviewer to bjacob for now, talking with joe to see if he can review it instead.

This enables the downloadable blacklist on Android devices. It was already enabled, but wasn't being processed. Note that this depends on the patch in bug 704710.

Also, this shouldn't be landed yet. We still have to deal with the issues reported in bug 700124 first.
Attachment #576656 - Flags: review?(bjacob)
(Assignee)

Updated

6 years ago
Attachment #576656 - Flags: review?(bjacob) → review?(joe)
Attachment #576656 - Flags: review?(joe) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 577861 [details] [diff] [review]
Patch v1.1, enable downloadable blacklist on Android devices.

Please review again, there were some changes made to support using Android SDK versions as the driver version field.
Attachment #576656 - Attachment is obsolete: true
Attachment #577861 - Flags: review?(joe)
(Assignee)

Comment 3

6 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=cffd58590c65
Comment on attachment 577861 [details] [diff] [review]
Patch v1.1, enable downloadable blacklist on Android devices.

Review of attachment 577861 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/GfxInfo.cpp
@@ +104,5 @@
> +    mAdapterDescription.Append(NS_LITERAL_STRING("', Manufacturer: '"));
> +    if (mozilla::AndroidBridge::Bridge()->GetStaticStringField("android/os/Build", "MANUFACTURER", str))
> +      mAdapterDescription.Append(str);
> +    mAdapterDescription.Append(NS_LITERAL_STRING("', Hardware: '"));
> +    PRInt32 version; // the HARDWARE field isn't available on Android SDK < 8

Maybe insert a blank line here.

@@ -297,5 @@
> -  // For now, we don't implement the downloaded blacklist.
> -  if (aDriverInfo.Length()) {
> -    *aStatus = nsIGfxInfo::FEATURE_NO_INFO;
> -    return NS_OK;
> -  }

Be sure that we don't return any built-in blocklist items (eg hard-coded in widget/src/android/GfxInfo.cpp) if aDriverInfo has any items in it. This makes sure we don't set our blacklist prefs on a downloaded blocklist ping unless they actually apply to us.
Attachment #577861 - Flags: review?(joe) → review+
(Assignee)

Updated

6 years ago
Blocks: 706702
(Assignee)

Comment 5

6 years ago
Created attachment 578491 [details] [diff] [review]
Patch v1.2, enable downloadable blacklist on Android devices.

Addressed code review, +r carried.
Attachment #577861 - Attachment is obsolete: true
Attachment #578491 - Flags: review+
(Assignee)

Comment 6

6 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=abe278c327db
(Assignee)

Comment 7

6 years ago
Created attachment 578763 [details] [diff] [review]
Patch v1.0, fix crash reporter on Android.

Refactored crash report annotation to happen after Init because with changes in "enable downloadable blacklist on Android devices", all device info is cached on Init.
Attachment #578763 - Flags: review?(bgirard)
Comment on attachment 578763 [details] [diff] [review]
Patch v1.0, fix crash reporter on Android.

:D
Attachment #578763 - Flags: review?(bgirard) → review+
(Assignee)

Comment 9

6 years ago
Created attachment 579855 [details] [diff] [review]
Patch v1.1, fix crash reporter on Android.

Rebased/unbitrotted, +r carried.
Attachment #578763 - Attachment is obsolete: true
Attachment #579855 - Flags: review+
(Assignee)

Comment 10

6 years ago
https://tbpl.mozilla.org/?rev=fe937bac6e75
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

6 years ago
https://hg.mozilla.org/mozilla-central/rev/b9c1b8afb35a
Target Milestone: --- → mozilla11
Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/544f5bc26164
See bug 711656 for explanation.
http://hg.mozilla.org/releases/mozilla-beta/rev/9af0904f0486 as well.
Depends on: 1006307
You need to log in before you can comment on or make changes to this bug.