809577 - nsIAudioManager undefined on desktop builds

Status: RESOLVED DUPLICATE of bug 809972

(Firefox OS Graveyard :: General, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Desktop builds get the following error on runtime:

JavaScript error: chrome://browser/content/settings.js, line 70: nsIAudioManager is undefined

We should ifdef around the gonk-only code.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: ifdef around gonk-only audiomanager code

Comment 2

[Ben Adida [:benadida]]

Comment on attachment 679319 [details] [diff] [review]
ifdef around gonk-only audiomanager code

I'm good with this but I suspect we need a brief review from B2G team.

Comment 3

[Marco Chen [:mchen]]

I verified that function is workable on Otoro with this patch. And thanks for the help on this regression.

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Marco Chen [:mchen] from comment #3)
> I verified that function is workable on Otoro with this patch. And thanks
> for the help on this regression.

Excellent.  Thank you, Marco!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Funny story, I already landed the patch in this one and mid-aired trying to mark it...
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f9dd07d9d64

Comment 7

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

No worries - as long as it works in the end!  Thanks as always, Ryan.

Comment 8

[Philipp von Weitershausen [:philikon]]

Thanks for creating the fix so quickly, Jed! For future reference, to avoid duplicating work, please make sure you mark regressions as blocking the bug that introduced the regression (bug 809972 in this case, as can be found out by hg blame.) That way folks who worked on and reviewed the original bug are aware of the regression.

Also, as Ben said, a B2G peer should have done the final review on this. The Bugzilla "etiquette" typically is that non-peers set feedback+ and only a peer sets review+. This is pretty universal across Gecko.

Comment 9

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thank you for the comments and clarification, Philipp.  I understand now what to do in the future.  Cheers!
j

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/6f9dd07d9d64