Do not update a translation with the slug of its parent

VERIFIED FIXED

Status

Mozilla Developer Network
Localization
P1
major
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: davidwalsh, Unassigned)

Tracking

Details

(Whiteboard: c=Editing p=3)

(Reporter)

Description

5 years ago
In researching other slug bugs, I found something very bad:  the incorrect translation slug is sent to the translation edit page.  To duplicate:

1.  Create an en-US document with a slug "html"
2.  Translate to French with a slug of "somethingelse"
3.  Click the edit button for the French document.
4.  Click "save changes"
5.  You'll see that the slug says "html", which is the slug of the root/parent document, *not* the French translation

My research shows that this never quite worked correctly.  If I pass the document_slug as the revision.slug, the translate page 404s.
(Reporter)

Comment 1

5 years ago
CC'ing other devs on this because it's a fairly large issue.
Severity: normal → major
(Reporter)

Comment 2

5 years ago
A few other things I'll point out:

1.  Redirects are being created properly, so this isn't the end of the world
2.  This is probably causing the occasional "slug is taken" warnings.
(Reporter)

Updated

5 years ago
Blocks: 782491
(Reporter)

Updated

5 years ago
Blocks: 798809
Whiteboard: c=Editing
Whiteboard: c=Editing → c=Editing p=
Priority: -- → P1
(Reporter)

Updated

5 years ago
QA Contact: dwalsh
Summary: Slug Translation Receives Wrong Slug → Do not update a translation with the slug of its parent
Component: Editing → Localization
Depends on: 810088
Depends on: 810089
Depends on: 810090
No longer blocks: 798809
Depends on: 798809
Whiteboard: c=Editing p= → c=Editing p=3

Comment 3

5 years ago
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/6ba1c1b220db88892f29c9da910ecc52ff7253aa
fix bug 809617 - Prevent document slug override

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
verified fixed translated the https://developer.allizom.org/en-US/docs/HTML/HTML5  to French
https://developer.allizom.org/fr/docs/HTML/HTML5testFrench and the new slug was saved
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.