809686 - Enable capitalization and word suggestions for Contacts' names, location, and notes

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Chris Peterson [:cpeterson]]

Set inputmode="latin-prose" to enable initial capitalization and word suggestions for new contacts' first name, last name, company name, street address, city, country, and notes fields.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: inputmode=latin-prose.patch

Set inputmode="latin-prose" to enable initial capitalization and word suggestions for new contacts' first name, last name, company name, street address, city, country, and notes fields.

Comment 2

[David Flanagan [:djf]]

Comment on attachment 679455 [details] [diff] [review]
inputmode=latin-prose.patch

feedback+  Looks good.  Note that the latest in bug 796544 is that we might change the inputmode attribute to x-inputmode.  But assuming that you land this soon, we'll just change it later in one big patch.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 679455 [details] [diff] [review]
inputmode=latin-prose.patch

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not a regression
User impact if declined: When entering new contacts, the user will need to manually shift to capitalize the contact's first name, last name, company name, city, and country. Android and iOS automatically capitalize these contact fields.
Testing completed: Tested locally
Risk to taking this patch (and alternatives if risky): Low risk because it just adds an inputmode hint to an existing text input.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 679455 [details] [diff] [review]
inputmode=latin-prose.patch

r?

Comment 5

[Jose Manuel Cantera]

changes look ok to me, just adding an attribute,  but for non latin languages what would the effect of that attribute?. I guess that for latin languages it will enable caps when cursor is positioned in the field and the field is empty, right?

Comment 6

[Chris Peterson [:cpeterson]]

Gecko doesn't do anything with the inputmode attribute; it simply passes the attribute value through to platform code, which may choose to display a special input widget. Gaia's non-latin IMEs currently ignore the inputmode attribute.

Gaia's latin IME switches the keyboard to uppercase mode when the cursor is positioned at the head of a text field, whether the text field is empty or not. The user can unshift the keyboard if they don't want the text field's first character to be capitalized.

Comment 7

[David Flanagan [:djf]]

If this hasn't landed yet, I think you should change inputmode to x-inputmode before landing.

Comment 8

[Mounir Lamouri (:mounir)]

Your patch will not work without that change.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The depends on bug has been used to close a blocking+ bug (bug 808921). So I guess this work is part of it. 

blocking-basecamp+.

Also make sure to fix mounir's comment before landing.

Comment 10

[Chris Peterson [:cpeterson]]

https://github.com/mozilla-b2g/gaia/pull/6445

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/1361f4544f6f521e4671357cd755f69ccc40932d

Comment 12

[sarsenyev]

Reviewed and verified on build: 2012123107020
"Unagi" device and "Gonk" OS