809695 - Enable capitalization and word suggestions for Task names

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: inputmode=latin-prose.patch

Set inputmode="latin-prose" to enable initial capitalization and word suggestions for new Tasks' names.

Comment 2

[David Flanagan [:djf]]

Comment on attachment 679472 [details] [diff] [review]
inputmode=latin-prose.patch

Review of attachment 679472 [details] [diff] [review]:
-----------------------------------------------------------------

feedback+, but note that we may later have to change inputmode to x-inputmode, per bug 796544

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 679472 [details] [diff] [review]
inputmode=latin-prose.patch

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not a regression
User impact if declined: When entering new Tasks, the user will need to manually shift to capitalize the task's title. Android's and iOS' "Notes" apps automatically capitalize the note's title.
Testing completed: Tested locally
Risk to taking this patch (and alternatives if risky): Low risk because it just adds an inputmode hint to an existing text input.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 679472 [details] [diff] [review]
inputmode=latin-prose.patch

Vivien, can you grant a+ for approval-gaia-master so I can submit a PR? This is a small UI patch with r+ and f+.

Comment 5

[David Flanagan [:djf]]

Please change inputmode to x-inputmode before landing.

Comment 6

[Mounir Lamouri (:mounir)]

(In reply to David Flanagan [:djf] from comment #5)
> Please change inputmode to x-inputmode before landing.

Your patch will not work without that change.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The depends on bug has been used to close a blocking+ bug (bug 808921). So I guess this work is part of it. 

blocking-basecamp+.

Also make sure to fix mounir's comment before landing.

Comment 8

[Chris Peterson [:cpeterson]]

https://github.com/mozilla-b2g/gaia/pull/6444

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6444

Pointer to Github pull-request

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/5b7a62c94918daa30bc8a167db9a67e204bde28d

Comment 11

[sarsenyev]

Reviewed and verified on build:2012123107020
on "Unagi" device "Gonk" OS