809745 - Entering 'localhost' in the location bar initiates a Google search

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Kyle Kalstabakken]

When you type 'localhost' in the location bar and hit enter, a Google search is performed.
This also occurs for any number of subdirectories, as long as you don't specify an actual file with file extension (ie, |localhost(/directory/)*|).

I expected to be shown the index page of the site I'm running on my machine. This does work if you type http://localhost

This first happens in the Nightly from Nov 3.

Just scanning the pushlog, it looks like this is caused by:
ded200210541	Abhishek Rajput — Bug 693808 - Make number keywords in locationbar be searched as normal terms. r=jst

... which makes sense because 'localhost' doesn't have any periods, colons or ?s in it. Adding any of these works as expected (eg, 'localhost:80', 'localhost?', 'localhost/index.html')

Comment 1

[Matthias Versen [:Matti]]

this is related to bug 150025

Comment 2

[João Rosado]

Also don't forget about internal network sites.
"myIntranetMachine/Site/" also causes the same problem and is a valid address.

As a note, these problems do not happen with browser.urlbar.trimURLs set to false.

Comment 3

[Jerry Baker]

(In reply to João Rosado from comment #2)
> As a note, these problems do not happen with browser.urlbar.trimURLs set to
> false.

They do using today's nightly. TrimURLs has no effect.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

abhishek, this was caused by your patch and seems like an important issue to resolve. Do you have any ideas how we could address it?

Comment 5

[Alex Keybl [:akeybl]]

Can we just backout bug 693808 from FF19 before the merge to prevent this from hitting Aurora and then resolve for FF20?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Yep - I'll do that.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Fixed by the backout of bug 693808.

Comment 10

[Jerry Baker]

This regressed again starting with today's nightly.

Comment 11

[Jerry Baker]

Oddly, 'localhost' doesn't trigger a Google search, but entering LAN machine names does.

Comment 12

[Jerry Baker]

In fact, the bug is even worse than that. It is now impossible with FF to visit a LAN machine. Typing 'http://vega' is automatically changed to http://www.vega.com, and 'vega' initiates a Google search.

Comment 13

[Jerry Baker]

Works again with a later build.

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Tested on: Windows 7x64, Ubuntu 12.10 and Mac OS X 10.8 - using Firefox 19 beta 5. 
Marking as verified fixed. 
If someone is able to reproduce, please reopen it.