809899 - WebIDL unions are broken in workers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I bet they don't really compile.  The problem is the different object representation workers use.  :(

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This is not an issue anymore, right?

Comment 2

[Boris Zbarsky [:bzbarsky]]

It can still be if a union includes a type that has both mainthread and worker descriptors with different nativeType.  The relevant code in Codegen.py:

                # FIXME: Unions are broken in workers.  See bug 809899.
                cgthings.append(CGUnionStruct(t, config.getDescriptorProvider(False)))
                cgthings.append(CGUnionStruct(t, config.getDescriptorProvider(False), True))

The arg passed to getDescriptorProvider() there is whether to provide worker descriptors or not.

One thing we could try to do is add a check somewhere that none of our unions in fact include an interface type with different descriptors on mainthread and workers, and then just wontfix this bug...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed; we no longer have worker descriptors.