Closed
Bug 809950
Opened 13 years ago
Closed 13 years ago
remove obvious static initializers from webrtc code
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: froydnj, Unassigned)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files)
1.66 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
1.11 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
The logging code and the wrapper code macros both create static initializers
with abandon. Fortunately they are easy to fix.
![]() |
Reporter | |
Comment 1•13 years ago
|
||
It's tricky to figure out a way to use LogCtx pointers in a way that won't
introduce static initializers...so let's not. Change the macros to use
something very close to the pattern used to fix bug 806618.
Attachment #679740 -
Flags: review?(rjesup)
![]() |
Reporter | |
Comment 2•13 years ago
|
||
The Wrapper code declares statics; let's hide those behind a function so that
they don't get initialized at library import time, but only when the WebRTC
Wrapper code actually gets invoked.
Attachment #679742 -
Flags: review?(rjesup)
Updated•13 years ago
|
Attachment #679740 -
Flags: review?(rjesup) → review+
Updated•13 years ago
|
Attachment #679742 -
Flags: review?(rjesup) → review+
![]() |
Reporter | |
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5905e2a217b9
https://hg.mozilla.org/mozilla-central/rev/244ced46ac11
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•