Closed Bug 809950 Opened 13 years ago Closed 13 years ago

remove obvious static initializers from webrtc code

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: froydnj, Unassigned)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

The logging code and the wrapper code macros both create static initializers with abandon. Fortunately they are easy to fix.
It's tricky to figure out a way to use LogCtx pointers in a way that won't introduce static initializers...so let's not. Change the macros to use something very close to the pattern used to fix bug 806618.
Attachment #679740 - Flags: review?(rjesup)
The Wrapper code declares statics; let's hide those behind a function so that they don't get initialized at library import time, but only when the WebRTC Wrapper code actually gets invoked.
Attachment #679742 - Flags: review?(rjesup)
Attachment #679740 - Flags: review?(rjesup) → review+
Attachment #679742 - Flags: review?(rjesup) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [qa-]
Depends on: 812278
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: