810139 - Update IdentityUtils.jsm to work with jsloader.reuseGlobal = true

Status: RESOLVED DUPLICATE of bug 809265

(Core Graveyard :: Identity, defect)

Description

[[:fabrice] Fabrice Desré]

Currently loading the marketplace on b2g, the navigator.id DOM component tries to load a jsm that fails:

E/GeckoConsole( 4112): [JavaScript Error: "resource://gre/modules/IdentityUtils.jsm - EXPORTED_SYMBOLS is not an array." {file: "jar:file:///system/b2g/omni.ja!/components/nsDOMIdentity.js" line: 19}]
E/GeckoConsole( 4112): [JavaScript Error: "NS_ERROR_FACTORY_NOT_REGISTERED: Factory not registered" {file: "https://login.persona.org/include.js" line: 8}]

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

I believe that once the patch for Bug 809265 lands, this will be fixed.  The problem is that some identity jsm and js modules appear to have been overlooked in the upgrade to the new global object architecture.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Fabrice Desré [:fabrice] from comment #1)
> Created attachment 679905 [details] [diff] [review]
> patch

Thank you for doing that, Fabrice, but the patch to Bug 809265 includes this.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to Jed Parsons [:jparsons] from comment #2)
> I believe that once the patch for Bug 809265 lands, this will be fixed.

Ok, that's great! It looks like that's ready to land. If not, can we land this simple fix first to make the Marketplace work again on the phone. In this case, perhaps you guys can r+ it.

> The problem is that some identity jsm and js modules appear to have been
> overlooked in the upgrade to the new global object architecture.

Yeah, fixing the world is hard when it takes a few days and code changes underneath you. Things were bound to be missed.

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> (In reply to Jed Parsons [:jparsons] from comment #2)
> > I believe that once the patch for Bug 809265 lands, this will be fixed.
> 
> Ok, that's great! It looks like that's ready to land. If not, can we land
> this simple fix first to make the Marketplace work again on the phone. In
> this case, perhaps you guys can r+ it.

Thank you Philipp, and please ignore my completely inaccurate Comment #3.  Bug 809265 is r=benadida already.

> > The problem is that some identity jsm and js modules appear to have been
> > overlooked in the upgrade to the new global object architecture.
> 
> Yeah, fixing the world is hard when it takes a few days and code changes
> underneath you. Things were bound to be missed.

Actually I'm pretty amazed how few glitches there were for an update of this magnitude.  Kudos to you and Kyle and everyone who pulled it off so quickly and cleanly!