809265 - Update Identity js and jsm modules to use new global object

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Bug 798491 reduces the number of system compartments in the main b2g object by having all JSMs and JS components share a common object.

All Identity modules need to be updated accordingly.


To quote Kyle's announcement explaining the nature of the changes:

Code in Gecko must now set "magic" properties (such as EXPORTED_SYMBOLS, the symbols themselves, and NSGetFactory) on the 'this' object instead of implicitly on the global via 'var', 'let', 'function', 'const', etc

So:

const EXPORTED_SYMBOLS = ["Foo", "Bar"];
let Foo = 3;
function Bar() { dump("hi"); }
var NSGetModule = ...;

becomes

this.EXPORTED_SYMBOLS = ["Foo", "Bar"];
this.Foo = 3;
this.Bar = function Bar() { dump("hi"); }
this.NSGetModule = ...;

Comment 1

[Jason Smith [:jsmith]]

Is this blocking issue I saw in IRC that's preventing testing on identity entirely if the identity trusted UI flow is prefed on?

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

This blocks everything until the Identity code is updated and re-landed, yes.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: use new global object

Update identity JSM and JS components for new global object architecture

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: use new global object

Replacing previous patch; didn't merge cleanly with m-c, and included a file that shouldn't have been included.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

tbpl: https://tbpl.mozilla.org/?tree=Try&rev=4c3a0ce8874b

Note - The try push includes the patch from Bug 809577, which has not yet landed.  This patch ifdefs around gonk-only code when building on desktop.

Comment 6

[Ben Adida [:benadida]]

Comment on attachment 679699 [details] [diff] [review]
use new global object

Review of attachment 679699 [details] [diff] [review]:
-----------------------------------------------------------------

looks great.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a84844aa40

Jed, can you make sure your future patches have your hg user information and a commit message? Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 9

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/d4a84844aa40

Comment 10

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a84844aa40
> 
> Jed, can you make sure your future patches have your hg user information and
> a commit message? Thanks!
> https://developer.mozilla.org/en-US/docs/
> Creating_a_patch_that_can_be_checked_in

Sorry about that, Ryan.  Yes, absolutely.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This is marked blocking-basecamp+, but does not apply cleanly to Aurora. Please post a branch-specific patch for uplift.

Comment 12

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Ryan VanderMeulen from comment #11)
> This is marked blocking-basecamp+, but does not apply cleanly to Aurora.
> Please post a branch-specific patch for uplift.

It seems to apply ok once toolkit/identity/IdentityUtils.jsm has been added.  Testing a patch now:

https://tbpl.mozilla.org/?tree=Try&rev=a868799244b9

Comment 13

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: aurora patch for updating js and jsm modules to use new global object

Comment 14

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Ryan VanderMeulen from comment #11)
> This is marked blocking-basecamp+, but does not apply cleanly to Aurora.
> Please post a branch-specific patch for uplift.

I think all that was missing was the existence of the file toolkit/identity/IdentityUtils.jsm.  I think Comment #13 has the patch you're looking for.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Thanks!

https://hg.mozilla.org/releases/mozilla-aurora/rev/a3f0f94bd774