Closed
Bug 809265
Opened 12 years ago
Closed 12 years ago
Update Identity js and jsm modules to use new global object
Categories
(Core Graveyard :: Identity, defect)
Core Graveyard
Identity
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)
People
(Reporter: jedp, Assigned: jedp)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files, 1 obsolete file)
6.56 KB,
patch
|
benadida
:
review+
|
Details | Diff | Splinter Review |
6.70 KB,
patch
|
Details | Diff | Splinter Review |
Bug 798491 reduces the number of system compartments in the main b2g object by having all JSMs and JS components share a common object. All Identity modules need to be updated accordingly. To quote Kyle's announcement explaining the nature of the changes: Code in Gecko must now set "magic" properties (such as EXPORTED_SYMBOLS, the symbols themselves, and NSGetFactory) on the 'this' object instead of implicitly on the global via 'var', 'let', 'function', 'const', etc So: const EXPORTED_SYMBOLS = ["Foo", "Bar"]; let Foo = 3; function Bar() { dump("hi"); } var NSGetModule = ...; becomes this.EXPORTED_SYMBOLS = ["Foo", "Bar"]; this.Foo = 3; this.Bar = function Bar() { dump("hi"); } this.NSGetModule = ...;
Comment 1•12 years ago
|
||
Is this blocking issue I saw in IRC that's preventing testing on identity entirely if the identity trusted UI flow is prefed on?
Assignee | ||
Comment 2•12 years ago
|
||
This blocks everything until the Identity code is updated and re-landed, yes.
Assignee | ||
Comment 3•12 years ago
|
||
Update identity JSM and JS components for new global object architecture
Attachment #679446 -
Flags: review?(benadida)
Assignee | ||
Comment 4•12 years ago
|
||
Replacing previous patch; didn't merge cleanly with m-c, and included a file that shouldn't have been included.
Attachment #679446 -
Attachment is obsolete: true
Attachment #679446 -
Flags: review?(benadida)
Attachment #679699 -
Flags: review?(benadida)
Assignee | ||
Comment 5•12 years ago
|
||
tbpl: https://tbpl.mozilla.org/?tree=Try&rev=4c3a0ce8874b Note - The try push includes the patch from Bug 809577, which has not yet landed. This patch ifdefs around gonk-only code when building on desktop.
Comment 6•12 years ago
|
||
Comment on attachment 679699 [details] [diff] [review] use new global object Review of attachment 679699 [details] [diff] [review]: ----------------------------------------------------------------- looks great.
Attachment #679699 -
Flags: review?(benadida) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a84844aa40 Jed, can you make sure your future patches have your hg user information and a commit message? Thanks! https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Keywords: checkin-needed
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d4a84844aa40
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•12 years ago
|
Whiteboard: [qa-]
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #8) > https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a84844aa40 > > Jed, can you make sure your future patches have your hg user information and > a commit message? Thanks! > https://developer.mozilla.org/en-US/docs/ > Creating_a_patch_that_can_be_checked_in Sorry about that, Ryan. Yes, absolutely.
Comment 11•12 years ago
|
||
This is marked blocking-basecamp+, but does not apply cleanly to Aurora. Please post a branch-specific patch for uplift.
Updated•12 years ago
|
status-firefox18:
--- → affected
status-firefox19:
--- → fixed
Whiteboard: [qa-] → [qa-] [needs-aurora-patch]
Updated•12 years ago
|
Whiteboard: [qa-] [needs-aurora-patch] → [qa-] [needs-aurora-patch] [qa-]
Updated•12 years ago
|
Whiteboard: [qa-] [needs-aurora-patch] [qa-] → [qa-] [needs-aurora-patch]
Assignee | ||
Comment 12•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #11) > This is marked blocking-basecamp+, but does not apply cleanly to Aurora. > Please post a branch-specific patch for uplift. It seems to apply ok once toolkit/identity/IdentityUtils.jsm has been added. Testing a patch now: https://tbpl.mozilla.org/?tree=Try&rev=a868799244b9
Assignee | ||
Comment 13•12 years ago
|
||
Assignee | ||
Comment 14•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #11) > This is marked blocking-basecamp+, but does not apply cleanly to Aurora. > Please post a branch-specific patch for uplift. I think all that was missing was the existence of the file toolkit/identity/IdentityUtils.jsm. I think Comment #13 has the patch you're looking for.
Comment 15•12 years ago
|
||
Thanks! https://hg.mozilla.org/releases/mozilla-aurora/rev/a3f0f94bd774
Whiteboard: [qa-] [needs-aurora-patch] → [qa-]
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•