81020 - order of hebrew text frame are wrong on Mac

Status: VERIFIED DUPLICATE of bug 80577

(Core :: Layout: Text and Fonts, defect)

Description

[Frank Tang]

I find this is still an issue after I fix 74124 the order of the hebew text are 
mostly right on Mac. But in some cases on Mac, it is wrong.
For example in http://hotmail.co.il/login.asp
1. the link should be on the left of the text
2. the line which have "90" is wrong
3. the line which have "Microsoft" is also wrong.

Comment 1

[Frank Tang]

reassign to myself

Comment 2

[Frank Tang]

Attachment: on mac- wrong display

Comment 3

[Frank Tang]

simon- could you take a look at the image ?
I need your help to debug this 

Comment 4

[Frank Tang]

Attachment: correct (I hope) screen shot from window

Comment 5

[Frank Tang]

simon- do you have a mac these days ?

Comment 6

[Frank Tang]

What I was trying to say was that the Hebrew in your screenshot has been
ordered with base direction left-to-right instead of right-to-left. In
Windows when mRightToLeftText is true in nsRenderingContextWin.cpp we call
SetTextAlign with TA_RTLREADING, which sets the base direction for the
device context's native reordering to right-to-left. You have to find the
equivalent API for Mac and call it.

Hope this helps, I'm off to bed now.

Simon

Comment 7

[Frank Tang]

the previous log is a cut&paste from simon's email. I don't understand what he 
mean "native device context direction"

Comment 8

[Simon Montagu :smontagu]

What I meant was the base (paragraph) direction used when the platform invokes 
its own implementation of the Bidi algorithm. This is important, because it 
determines whether a logical text like

COPYRIGHT 2000 MICROSOFT

is rendered

TGHIRYPOC 2000 TFOSORCIM   <--- with LTR base direction

or

TFOSORCIM 2000 THGIRYPOC   <--- with RTL base direction

In Windows this is set by calling SetTextAlign with the flag TA_RTLREADING (by 
the way the comment in the source of nsRenderingContextWin.cpp is not 
synchronized with the code -- I'll file a separate bug on that).

Comment 9

[Frank Tang]

no time to work on mac arabic/hebrew. move to future

Comment 10

[Andreas Becker]

Changing QA contact to [e-mail].

Changing component to "Bidi..." and adding intl keyword.

Comment 11

[basic]

Can someone post a testcase? The URL doesn't seem to work

Comment 12

[Simon Montagu :smontagu]

Try http://www.hotmail.co.il/login.asp

Comment 13

[Simon Montagu :smontagu]

Can someone revisit this testcase after the checkin on bug 83958 and attach a
new screenshot? The testcase includes Bidi control characters, which would
explain the ? symbols in attachment 34592 [details]

Comment 14

[timeless]

I'm moving the comments to the other bug.

*** This bug has been marked as a duplicate of 80577 ***

Comment 15

[Matt Perry]

Verified dupe