Closed
Bug 810415
Opened 12 years ago
Closed 12 years ago
Support mini-app mode on Galaxy Note II and Galaxy SIII
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file, 1 obsolete file)
3.45 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Some new Samsung devices have a multi-app mode where two apps are on screen at the same time. Chrome/Facebook/Twitter support it. We should support too if we can. Samsung doesn't seem to have instructions, but I found: http://www.modaco.com/topic/358471-developers-add-support-for-samsung-multi-window-to-your-apps/ which seems simple and worth trying.
Updated•12 years ago
|
Summary: Support mini-app mode on Galaxy Note II → Support mini-app mode on Galaxy Note II and Galaxy SIII
Assignee | ||
Comment 1•12 years ago
|
||
This does exactly what's listed in the blog post. I have no idea if it works, but there's a build at: https://dl.dropbox.com/u/72157/fennecMultiWindow.apk
Assignee | ||
Comment 2•12 years ago
|
||
Removed some tabs for spaces. AaronMT has some screenshots of this working. Are we happy taking this with limited testing mfinkle?
Attachment #680178 -
Attachment is obsolete: true
Attachment #680184 -
Flags: review?(mark.finkle)
Comment 3•12 years ago
|
||
Comment on attachment 680184 [details] [diff] [review] Patch >+ <uses-library required="false" name="com.sec.android.app.multiwindow"> </uses-library> >+ <meta-data android:name="com.sec.android.support.multiwindow" android:value="true" /> >+ <meta-data android:name="com.sec.android.multiwindow.DEFAULT_SIZE_W" android:resource="@dimen/app_defaultsize_w" /> >+ <meta-data android:name="com.sec.android.multiwindow.DEFAULT_SIZE_H" android:resource="@dimen/app_defaultsize_h" /> >+ <meta-data android:name="com.sec.android.multiwindow.MINIMUM_SIZE_W" android:resource="@dimen/app_minimumsize_w" /> >+ <meta-data android:name="com.sec.android.multiwindow.MINIMUM_SIZE_H" android:resource="@dimen/app_minimumsize_h" /> I assume the required="false" keeps this from breaking Firefox on non-multilauncher devices? >diff --git a/mobile/android/base/resources/values/dimens.xml b/mobile/android/base/resources/values/dimens.xml >+ <dimen name="app_defaultsize_w">632.0dip</dimen> >+ <dimen name="app_defaultsize_h">598.0dip</dimen> >+ <dimen name="app_minimumsize_w">632.0dip</dimen> >+ <dimen name="app_minimumsize_h">598.0dip</dimen> How did you arrive at these numbers? r+, but push to Try first, just in case.
Attachment #680184 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•12 years ago
|
||
I stole the dimens them from the forum post as a first pass attempt. I don't have a good feel for what we want, but I figure we can easily tweak them afterwards. Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=032af8970bc6
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc88f1602468
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bc88f1602468
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Comment 7•11 years ago
|
||
TC added in Firefox Mobile: OS Integration for 19 tablets, 19 phones, 20 tablets, 20 phones. https://moztrap.mozilla.org/manage/case/5941/
Flags: in-moztrap+
Comment 8•11 years ago
|
||
Just to note this was backed out in the bug referenced above. We need to get more hardware that supports the different Mini-app modes so that the interaction can be evaluated. * Need a 7 or 8 inch Samsung tablet that supports this * Need a 10 inch tablet * Already have Galaxy Note and Galaxy SIII
Comment 9•11 years ago
|
||
(In reply to Kevin Brosnan [:kbrosnan] from comment #8) > * Need a 7 or 8 inch Samsung tablet that supports this > * Need a 10 inch tablet > * Already have Galaxy Note and Galaxy SIII http://en.wikipedia.org/wiki/TouchWiz Anything with 'TouchWiz Nature UX' currently supports it. At this time no tablets.
Comment 10•11 years ago
|
||
http://www.gsmarena.com/samsung_galaxy_note_10_1_n8000-4573.php supports it.
Comment 11•10 years ago
|
||
As mentioned in Issue #854040 : See https://f-droid.org/forums/topic/request-add-support-for-samsung-multi-window/ for HOWTO enable Samsung Multi-Window support (by adding few lines to the manifest) + link to official Samsung docs + link to XDA forum describing the same. There are actually two Samsung-specific features: Multi-Window (=two apps displayed tiled side-by-side) and Pen-Window (=one app displayed in a "window" over a normal app). Both of them are managed by Samsung's code, all we need to do to leverage these features for Fennec is to adjust its manifest. Feel free to contact me if testing of a custom Fennec APK with modified manifest on SGS3, Note8 and Note 10.1 2014 will be required.
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•