81054 - Priority not shown in message pane (header envelope)

Status: NEW

(Thunderbird :: Message Reader UI, enhancement)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Read a msg with Priority header existant and Priority != normal.
2. Look at the header section of the msg pane.

Actual result:
No Priority shown.

Expected result:
Priority is visible in some way.

Rationale:
It is true that Priority is most important to be shown in the thread pane, but I
might want to see it in the msg pane, e.g. when I disabled the Priority column.
It is an important property of the msg and thus should be shown in the msg pane.

Comment 1

[(not reading, please use [e-mail] instead)]

mscott is the message display guru.

marking enhancement.  cc'ing jglick for UI comments.

Comment 2

[Scott MacGregor]

futuring so we can consider this enchancement in a future version.

Comment 3

[u63580]

*** Bug 311184 has been marked as a duplicate of this bug. ***

Comment 4

[u63580]

*** Bug 311184 has been marked as a duplicate of this bug. ***

Comment 5

[Przemyslaw Bialik]

Attachment: Proposed fix v1

Shows priority header in the expanded header view.

This patch is the reply to the Bug 410749 comment #19 ;)

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 367242 [details] [diff] [review]
Proposed fix v1

Looks good so far. The only addition I'd like to see is some help explaining the priority to the person.  I think we can minimally do this with two changes to your code.

add a css rule to make the priority value use the { cursor: help; }.  I'd like to indicate that information is available in the title to explain the priority.

Then also add a title attribute to the priority value such that it explains what it means.  The text should look something like: "$SENDER marked this message priority $PRIORITY"

Comment 7

[Przemyslaw Bialik]

Thanks for the detailed comments, I will play with these enhancements.

Comment 8

[Robert Kaiser]

Hmm, this bug is filed in SeaMonkey, the patch is Thunderbird-only though. Is this not relevant to SeaMonkey an more? Is a fix upcoming that addresses SeaMonkey as well?

Comment 9

[Ben Bucksch (:BenB)]

As the bug filer, moving it to Thunderbird.
I encourage the patch author to fix it for seamonkey as well, though.

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 367242 [details] [diff] [review]
Proposed fix v1

Patch has bitrotted - Przemyslaw, up for a new patch? :)

$ patch -p1 --dry-run < ~/Desktop/p81054.diff 
patching file mail/base/content/msgHdrViewOverlay.js
Hunk #1 FAILED at 216.
Hunk #2 FAILED at 455.
2 out of 2 hunks FAILED -- saving rejects to file mail/base/content/msgHdrViewOverlay.js.rej
patching file mail/base/content/msgHdrViewOverlay.xul
Hunk #1 FAILED at 209.
1 out of 1 hunk FAILED -- saving rejects to file mail/base/content/msgHdrViewOverlay.xul.rej
patching file mail/locales/en-US/chrome/messenger/msgHdrViewOverlay.dtd
Hunk #1 FAILED at 49.
1 out of 1 hunk FAILED -- saving rejects to file mail/locales/en-US/chrome/messenger/msgHdrViewOverlay.dtd.rej
patching file mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp
Hunk #1 FAILED at 236.
1 out of 1 hunk FAILED -- saving rejects to file mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp.rej

Comment 11

[Przemyslaw Bialik]

Sorry for late reply... I don't have currently resources to play with it so unassigning