810742 - IndexError: list index out of range python/mach/mach/main.py", line 323, in _run initial_file = stack[0][0]

Status: VERIFIED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[:Gavin Sharp [email: [e-mail]]]

Just tried setting up my build environment on Windows 8. I installed all the pre-requesites, created a simple .mozconfig, and ran "mach build". configure failed because I hadn't yet installed the DirectX SDK:

> 0:25.94 checking for jar... :
> 0:26.25 ERROR: Invalid key name.
> 0:26.25 Type "REG QUERY /?" for usage.
> 0:26.29 configure: error: Couldn't find the DirectX SDK, needed for WebGL. Either install it (June 2010 version or newer), or reconfigure with --disable-webgl.
> 0:26.30 *** Fix above errors and then restart with               "c:/mozilla-build/python/python.exe c:/Users/Gavin/moz/mozilla-central/build/pymake/pymake/../make.py -f client.mk build"
> 0:26.32 c:\Users\Gavin\moz\mozilla-central\client.mk:310:0: command 'cd c:/Users/Gavin/moz/mozilla-central/obj-ff-debug &&  MAKE="c:/mozilla-build/python/python.exe c:/Users/Gavin/moz/mozilla-central/build/pymake/pymake/../make.py"  c:/Users/Gavin/moz/mozilla-central/configure  \
> 0:26.32   || ( echo "*** Fix above errors and then restart with\
> 0:26.32                \"c:/mozilla-build/python/python.exe c:/Users/Gavin/moz/mozilla-central/build/pymake/pymake/../make.py -f client.mk build\"" && exit 1 )' failed, return code 1
> 0:26.32 c:\Users\Gavin\moz\mozilla-central\client.mk:322:0: command 'c:/mozilla-build/python/python.exe c:/Users/Gavin/moz/mozilla-central/build/pymake/pymake/../make.py -f c:/Users/Gavin/moz/mozilla-central/client.mk configure' failed, return code 2
> 0:26.32 c:\Users\Gavin\moz\mozilla-central\client.mk:152:0: command 'c:/mozilla-build/python/python.exe c:/Users/Gavin/moz/mozilla-central/build/pymake/pymake/../make.py -f c:/Users/Gavin/moz/mozilla-central/client.mk realbuild' failed, return code 2
> 0:26.46 0 compiler warnings present.

This was followed by:

Error running mach:

    ['build']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=mach


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

IndexError: list index out of range

  File "c:\Users\Gavin\moz\mozilla-central\python/mach\mach\main.py", line 215, in run
    return self._run(argv)
  File "c:\Users\Gavin\moz\mozilla-central\python/mach\mach\main.py", line 323, in _run
    initial_file = stack[0][0]

Comment 1

[Gregory Szorc [:gps]]

Huh? It certainly seems like you've stumbled across a bug in the error handling. But, we shouldn't even get to this code - at least not with a tree newer than the middle of last week. How old is your tree?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

It was cloned from m-c a few minutes before I filed the bug.

Comment 3

[Gregory Szorc [:gps]]

Gavin: I don't suppose I could gain physical access or remote desktop to the machine experiencing this issue? The error at line 323 should never happen and I would like to crack open a Python debugging session to poke at state.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sure. I haven't set up RDP, so it'll have to wait until I get back home tonight :)

Comment 5

[Gregory Szorc [:gps]]

Waiting for Gavin to allow me to go to town with the Python debugger.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I have provided the info!

Comment 8

[Gregory Szorc [:gps]]

Attachment: Handle exceptions thrown by callee with no stack, v1

I was able to reproduce this error using other means. This patch fixes mach to print out a useful error message.

Gavin: if you apply this patch, you should get a different error message that should reveal the actual problem. Please post it.

Comment 9

[Gregory Szorc [:gps]]

I'm relatively confident I fixed the underlying issue in bug 818628.

Reshaping this bug to track proper exception handling.

Comment 10

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/c3a34455b82e

I'd still like Gavin and others to confirm the configure error has disappeared.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

With the patch applied, I now get:
AssertionError
  File "c:\Users\gps\moz\mozilla-central\python/mach\mach\main.py", line 306, in _run
    assert isinstance(result, int) 

More output: http://pastebin.mozilla.org/1978839

Comment 12

[Gregory Szorc [:gps]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #11)
> With the patch applied, I now get:
> AssertionError
>   File "c:\Users\gps\moz\mozilla-central\python/mach\mach\main.py", line
> 306, in _run
>     assert isinstance(result, int) 
> 
> More output: http://pastebin.mozilla.org/1978839

This was fixed in bug 818628. Update your tree and it will go away. I'm pretty confident we got both underlying issues.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Yep, updating to current tip fixed it. Now I just see a normal configure error.

Comment 14

[Balaji]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #11)
> With the patch applied, I now get:
> AssertionError
>   File "c:\Users\gps\moz\mozilla-central\python/mach\mach\main.py", line
> 306, in _run
>     assert isinstance(result, int) 
> 
> More output: http://pastebin.mozilla.org/1978839

Hi,
Could you please say how to apply the patch? I am totally new to this environment.

Thanks,
Bala

Comment 15

[:Gavin Sharp [email: [e-mail]]]

The patch was checked in to mozilla-central, so the easiest option is probably to just update your build (hg pull -u or equivalent).