818628 - AssertionError python/mach/mach/main.py", line 306, in _run assert isinstance(result, int)

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Ed Morley [:emorley]]

Win7x64
MozillaBuild 1.6.1
VS2010

Building from:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5488aa7e3fc3

Mozconfig:
{
mk_add_options MOZ_OBJDIR=d:/obj-inbound

ac_add_options --disable-optimize
ac_add_options --disable-debug-symbols
ac_add_options --disable-tests

#ac_add_options --disable-webrtc
#ac_add_options --disable-angle
#ac_add_options --enable-debug
}

{
13:28.60 <webrtc_vp8.lib.desc>: Found error
13:28.70 <libs>: Found error
13:28.72 d:\src-gecko\inbound\config\makefiles\target_libs.mk:27:0: command 'c:/mozilla-bu
ild/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -C src/modules/v
ideo_coding/codecs/vp8/vp8_webrtc_vp8 libs' failed, return code 2
13:28.72 <libs>: Found error
13:28.87 d:\src-gecko\inbound\config\makefiles\target_libs.mk:60:0: command 'c:/mozilla-bu
ild/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -C trunk libs' f
ailed, return code 2
13:28.87 d:\src-gecko\inbound\config\makefiles\target_libs.mk:18:0: command 'c:/mozilla-bu
ild/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -C media/webrtc
libs' failed, return code 2
13:28.87 d:\src-gecko\inbound\config\rules.mk:583:0: command 'c:/mozilla-build/python/pyth
on.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py libs_tier_platform' failed, ret
urn code 2
13:28.87 d:\src-gecko\inbound\config\rules.mk:548:0: command 'c:/mozilla-build/python/pyth
on.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py  tier_platform' failed, return
code 2
13:28.87 d:\src-gecko\inbound\client.mk:360:0: command 'c:/mozilla-build/python/python.exe
 d:/src-gecko/inbound/build/pymake/pymake/../make.py -j8 -C d:/obj-inbound' failed, return
 code 2
13:28.87 d:\src-gecko\inbound\client.mk:160:0: command 'c:/mozilla-build/python/python.exe
 d:/src-gecko/inbound/build/pymake/pymake/../make.py -f d:/src-gecko/inbound/client.mk rea
lbuild' failed, return code 2
13:29.06 742 compiler warnings present.
Error running mach:

    ['-l', 'c:/mozilla/_build.log', 'build']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=mach


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

IndexError: list index out of range

  File "d:\src-gecko\inbound\python/mach\mach\main.py", line 214, in run
    return self._run(argv)
  File "d:\src-gecko\inbound\python/mach\mach\main.py", line 322, in _run
    initial_file = stack[0][0]
}

Comment 1

[Ed Morley [:emorley]]

Oh and the build log file is still 0 bytes.

Comment 2

[Ed Morley [:emorley]]

My .profile contains:

LOGS_DIR="/c/mozilla"
INBOUND_DIR="/d/src-gecko/inbound"
...
...

build() {
  $INBOUND_DIR/mach -l $LOGS_DIR/_build.log build
}

Comment 3

[Gregory Szorc [:gps]]

I have a patch for the IndexError in bug 810742. Please apply that and update the bug with the newer error details.

Comment 4

[Ed Morley [:emorley]]

{
 2:53.93 <webrtc_vp8.lib.desc>: Found error
 2:53.93 <libs>: Found error
 2:53.93 d:\src-gecko\inbound\config\makefiles\target_libs.mk:27:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -C src/modules/video_coding/codecs/vp8/vp8_webrtc_vp8 libs' failed, return code 2
 2:53.93 <libs>: Found error
 2:53.93 d:\src-gecko\inbound\config\makefiles\target_libs.mk:60:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -C trunk libs' failed, return code 2
 2:53.93 d:\src-gecko\inbound\config\makefiles\target_libs.mk:18:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -C media/webrtc libs' failed, return code 2
 2:53.93 d:\src-gecko\inbound\config\rules.mk:583:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py libs_tier_platform' failed, return code 2
 2:53.93 d:\src-gecko\inbound\config\rules.mk:548:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py  tier_platform' failed, return code 2
 2:53.93 d:\src-gecko\inbound\client.mk:360:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -j8 -C d:/obj-inbound' failed, return code 2
 2:53.93 d:\src-gecko\inbound\client.mk:160:0: command 'c:/mozilla-build/python/python.exe d:/src-gecko/inbound/build/pymake/pymake/../make.py -f d:/src-gecko/inbound/client.mk realbuild' failed, return code 2
 2:54.02 742 compiler warnings present.
The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AssertionError

  File "d:\src-gecko\inbound\python/mach\mach\main.py", line 306, in _run
    assert isinstance(result, int)
}

Comment 5

[Gregory Szorc [:gps]]

wat? This should not happen.

edmorley: Please add the following to line 305 of /python/mach/mach/main.py:

    print(type(result))
    print(result)

And let me know what that prints.

Comment 6

[Ed Morley [:emorley]]

Thank you :-)

<type 'long'>
2

Comment 7

[Gregory Szorc [:gps]]

Attachment: Handle long, v1

*facepalm*

Don't worry about you not being a peer - mach doesn't have a module... yet.

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 688904 [details] [diff] [review]
Handle long, v1

Thank you :-)

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/ee134c770558

Comment 10

[(not currently active) Ted Mielczarek]

(In reply to Gregory Szorc [:gps] from comment #7)
> Don't worry about you not being a peer - mach doesn't have a module... yet.

FWIW, module owners/peers have long had the ability to request review from others for their module at their discretion.