create test file to check proper handling/rejection of certain values input into the Account manager

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Account Manager
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 23.0
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

14.61 KB, patch
aceman
: review+
Details | Diff | Splinter Review
13.48 KB, patch
neil@parkwaycc.co.uk
: review+
mconley
: feedback+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
I can do a mozmill test to check correct operation of code added in bug 80855, bug 327812, bug 208628, bug 530142, bug 720199, bug 536768. Let's call it test-account-values.js.
++
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 716262 [details] [diff] [review]
patch

I try to do bug 80855 in a separate xpcshell test as it does not need the full UI running.
Attachment #716262 - Flags: review?(mconley)
Comment on attachment 716262 [details] [diff] [review]
patch

Review of attachment 716262 [details] [diff] [review]:
-----------------------------------------------------------------

These are really well written tests, and they pass for me with flying colours. Thumbs up, I love it.

::: mail/test/mozmill/account/test-account-values.js
@@ +5,5 @@
> +/**
> + * This test checks proper operation of the account settings panes
> + * when certain special or invalid values are entered into the fields.
> + *
> + * New checks can be added to it as needed.

I think this is implied - can probably remove this line.
Attachment #716262 - Flags: review?(mconley) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 728645 [details] [diff] [review]
patch v2

Oh, finally :)
Attachment #716262 - Attachment is obsolete: true
Attachment #728645 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Whiteboard: [please leave open for the remaining test]
https://hg.mozilla.org/comm-central/rev/4943b8dbd039
Keywords: checkin-needed
(Assignee)

Comment 6

4 years ago
Created attachment 734291 [details] [diff] [review]
test for 80855

The remaining test. Neil, can you think up any invalid IPs/hostnames to add?
Attachment #734291 - Flags: review?(neil)
Attachment #734291 - Flags: feedback?(mconley)

Comment 7

4 years ago
Comment on attachment 734291 [details] [diff] [review]
test for 80855

Seems reasonable, but do you want to add things like 127.1 and 10.100.1000 as valid extended IP addresses?
Attachment #734291 - Flags: review?(neil) → review+
(Assignee)

Comment 8

4 years ago
These will not currently pass. I see these are valid as even 'ping' in linux accepts them fine. I remember we discussed them in bug 80855. We have bug 809609 to add support of these. We can update the test in that bug.
Blocks: 809609
Keywords: checkin-needed
Whiteboard: [please leave open for the remaining test]
Comment on attachment 734291 [details] [diff] [review]
test for 80855

Those are some good looking tests! +1!
Attachment #734291 - Flags: feedback?(mconley) → feedback+
https://hg.mozilla.org/comm-central/rev/6230fb9db54d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.