Last Comment Bug 810763 - create test file to check proper handling/rejection of certain values input into the Account manager
: create test file to check proper handling/rejection of certain values input i...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Account Manager (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 23.0
Assigned To: :aceman
:
:
Mentors:
Depends on: 80855 208628 327812 530142 536768 720199
Blocks: 809609
  Show dependency treegraph
 
Reported: 2012-11-11 23:41 PST by :aceman
Modified: 2013-04-13 05:13 PDT (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (14.66 KB, patch)
2013-02-20 15:09 PST, :aceman
mconley: review+
Details | Diff | Splinter Review
patch v2 (14.61 KB, patch)
2013-03-23 11:21 PDT, :aceman
acelists: review+
Details | Diff | Splinter Review
test for 80855 (13.48 KB, patch)
2013-04-06 13:34 PDT, :aceman
neil: review+
mconley: feedback+
Details | Diff | Splinter Review

Description :aceman 2012-11-11 23:41:18 PST
I can do a mozmill test to check correct operation of code added in bug 80855, bug 327812, bug 208628, bug 530142, bug 720199, bug 536768. Let's call it test-account-values.js.
Comment 1 Wayne Mery (:wsmwk, NI for questions) 2012-11-12 05:31:04 PST
++
Comment 2 :aceman 2013-02-20 15:09:08 PST
Created attachment 716262 [details] [diff] [review]
patch

I try to do bug 80855 in a separate xpcshell test as it does not need the full UI running.
Comment 3 Mike Conley (:mconley) - (needinfo me!) 2013-03-23 11:17:54 PDT
Comment on attachment 716262 [details] [diff] [review]
patch

Review of attachment 716262 [details] [diff] [review]:
-----------------------------------------------------------------

These are really well written tests, and they pass for me with flying colours. Thumbs up, I love it.

::: mail/test/mozmill/account/test-account-values.js
@@ +5,5 @@
> +/**
> + * This test checks proper operation of the account settings panes
> + * when certain special or invalid values are entered into the fields.
> + *
> + * New checks can be added to it as needed.

I think this is implied - can probably remove this line.
Comment 4 :aceman 2013-03-23 11:21:54 PDT
Created attachment 728645 [details] [diff] [review]
patch v2

Oh, finally :)
Comment 5 Mark Banner (:standard8) 2013-03-26 04:30:05 PDT
https://hg.mozilla.org/comm-central/rev/4943b8dbd039
Comment 6 :aceman 2013-04-06 13:34:50 PDT
Created attachment 734291 [details] [diff] [review]
test for 80855

The remaining test. Neil, can you think up any invalid IPs/hostnames to add?
Comment 7 neil@parkwaycc.co.uk 2013-04-07 10:25:11 PDT
Comment on attachment 734291 [details] [diff] [review]
test for 80855

Seems reasonable, but do you want to add things like 127.1 and 10.100.1000 as valid extended IP addresses?
Comment 8 :aceman 2013-04-07 12:53:57 PDT
These will not currently pass. I see these are valid as even 'ping' in linux accepts them fine. I remember we discussed them in bug 80855. We have bug 809609 to add support of these. We can update the test in that bug.
Comment 9 Mike Conley (:mconley) - (needinfo me!) 2013-04-11 00:43:33 PDT
Comment on attachment 734291 [details] [diff] [review]
test for 80855

Those are some good looking tests! +1!
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-04-13 05:13:01 PDT
https://hg.mozilla.org/comm-central/rev/6230fb9db54d

Note You need to log in before you can comment on or make changes to this bug.