Linux (2001-05-15-05 trunk) Win32 (2001-05-15-06 trunk) Mac (2001-05-15-04 trunk) Summary: In a separate winodw, Go|Next|Flagged message shouldn't be grayed out Steps: 1. From the Inbox, double click on a message to open a separate thread window 2. From the Go menu, select Next or Previous. Actual result: The Flagged Message submenu is grayed out. Expected result: It should not gray out. It should work like Nova 4.7 This occurs on Linux and Win32. On Mac, all the submenus in Go->Next or Previous got grayed out.
Applies to Go|Previous|Flagged as well as Go|Next|Flagged. Problem exists in Thunderbird as well as the suite; I'll move it there under the assumption that the feature is more likely to be fixed there, especially given the recent revamping of "Flag" to "Star".
heh, still evident version 3.0a1pre (2007112004)
Created attachment 304074 [details] [diff] [review] proposed fix Works fine, only the enabling was missing... Fix for thunderbird and seamonkey.
Comment on attachment 304074 [details] [diff] [review] proposed fix r=me with that |return true;| below where you put cmd_previousFlaggedMsg removed - bug 339175 should have moved the finds up instead of making two separate cases for always-true, and bug 74959 putting forward/back in the find case is a nice demonstration of why it should have.
Comment on attachment 304074 [details] [diff] [review] proposed fix Nit: for some reason in SeaMonkey we seem to put nextFlaggedMessage between nextUnreadMessage and nextUnreadThread...
Created attachment 304274 [details] [diff] [review] proposed fix (for checkin) Patch I will checkin. Adjusted the order for tb too.
Thanks for the quick reviews! Checking in mail/base/content/messageWindow.js; /cvsroot/mozilla/mail/base/content/messageWindow.js,v <-- messageWindow.js new revision: 1.58; previous revision: 1.57 done Checking in mailnews/base/resources/content/messageWindow.js; /cvsroot/mozilla/mailnews/base/resources/content/messageWindow.js,v <-- messageWindow.js new revision: 1.118; previous revision: 1.117 done ->FIXED