810992 - ?next= parameter on login page does not work

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Fred Wenzel [:wenzel]]

STR:
- while logged out, access a page that requires login, such as: https://mozillians.org/en-US/u/aakashd
- it'll take you to:
https://mozillians.org/en-US/?next=/en-US/u/aakashd
- log in.

note this will take you to the front page, not where you wanted to go.

mkelly points out that mozillians overrides login_success, which is where django_browserid would normally handle such a parameter:
<https://github.com/mozilla/mozillians/blob/master/apps/users/views.py#L34>
<https://github.com/mozilla/django-browserid/blob/master/django_browserid/views.py#L21>

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/543ade2202a8848daa37e79c323e451fe08d0fe9
[fix bug 810992] Redirect to ?next= page after login.

Comment 3

[Ben (:bensternthal)]

Tested on stage.

Comment 4

[Matt Brandt [:mbrandt]]

Reopening:

This appears to have regressed on dev and stage. Not reproducible on prod.

Steps to reproduce:
1. as a logged out user, goto https://mozillians.allizom.org/en-US/?next=/en-US/group/beards/
2. login with a vouched Mozillians account

Expected:
After logging in, the browser redirects to the /beards/ group

Actual:
Browser redirects to the users homepage.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

Thanks Matt!

https://github.com/mozilla/mozillians/pull/524

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/935ae8d9cdc46f2a56abcb9b43d0985ead6dbb8a
[fix bug 810992] Support ?next on login.

https://github.com/mozilla/mozillians/commit/211af10fc30d335c3a930d616e9474345b8cfc39
Merge pull request #524 from glogiotatidis/810992

[fix bug 810992] Support ?next on login.

Comment 7

[Matt Brandt [:mbrandt]]

Looks fantastic, thanks Giorgos - QA verified on stage.  ?next= works great