811089 - Remove workarounds for bug 803255 once it's fixed

Status: NEW

(Firefox :: Bookmarks & History, task, P5)

Description

[:Felipe Gomes (needinfo for replies!)]

Bug 803255 fixed a bug where a document viewer would be leaked if the document was navigated away in a frame that is not currently being displayed (e.g. on a collapsed sidebar).

At least bug 802435 and bug 728426 had workaround for that. We need to see if those can be removed and, if so, remove them.
(I've already checked that 802435 indeed can, haven't tried 728426 yet)

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 682233 [details] [diff] [review]
Patch

worked fine on try and helped fix the test problem from bug 809274

Comment 3

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfb675fa9fbd

Leaving open to investigate if bug 728426 can also be reverted

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfb675fa9fbd

Comment 5

[Takanori MATSUURA]

I suppose we don't need "leave open" anymore?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

This bug is still valid, for reverting bug 728426.

The code in question is the manual clean-up here that was done to avoid a leak: [1]. Someone would need to remove it and ensure that no leak occurs. However, since it's fairly innocuous code, this is unlikely to be important, so I'm marking it as a P5.

[1] https://searchfox.org/mozilla-central/rev/444ee13e14fe30451651c0f62b3979c76766ada4/testing/mochitest/browser-test.js#924-932

Comment 7

[Marco Bonardo [:mak]]

So basically, we should revert the change to browser/base/content/browser.js from bug 728426 and check if leaks are coming back, if not we can land it.
https://bugzilla.mozilla.org/show_bug.cgi?id=728426#c6 suggests a way to reproduce.

Comment 8

[Falguni Islam]

Hello I am an outreachy accepted applicant can I work on this bug.

Comment 9

[Marco Bonardo [:mak]]

Hello, please look at the list of bugs at https://codetribute.mozilla.org/projects/ff that have an active mentor, before looking at the huge list of bugs in bugzilla, I'd suggest starting from a good-first-bug and only later move to more complicate issues.