809274 - social may try and hide sidebar multiple times causing errors in the console

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

The social sidebar may end up having setSidebarVisibilityState(false) called multiple times without a "true" call in between.  This primarily happens in tests when the sidebar is made visible then invisible before the sidebar load event fires.

The end result is errors written to the console (and these messages end up in the test logs too) - however, no test failures actually occur, so this need only land on m-c

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Check the current state of the sidebar before changing it.

tests all pass with this.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: updated to actually set isActive and uses docShellIsActive property

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fd41b40e88f

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/5a2f571e1f6d for the weirdest set of later tests timing out.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Re-landed the same patch together with the patch from bug 811089 which will fix the test timeout from the previous attempt

https://hg.mozilla.org/integration/mozilla-inbound/rev/5672ca7c2551

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5672ca7c2551