811117 - Remove GetSelectedMessages from mail window and refactor some mail window code

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

Attachment: Remove GSM and refactor other code [Checked in: Comment 2]

This ports parts of:
* Bug 462681 - mailWindowOverlay.js style/whitespace/indention/comment/linewrap cleanup
* Bug 474701 - gloda global search on toolbar, folder display refactoring mega-bug

It also includes a refactoring of the ComposeMsgByType function so that some code duplication can be removed.

Comment 1

[Karsten Düsterloh]

Comment on attachment 680818 [details] [diff] [review]
Remove GSM and refactor other code [Checked in: Comment 2]

> function GetSelectedMessages()
>+  var mailWindow = gMsgCompose && Services.wm.getMostRecentWindow("mail:3pane");
>+  return mailWindow ? mailWindow.gFolderDisplay.selectedMessageUris : null;

You could just "return mailWindow && mailWindow.gFolderDisplay.selectedMessageUris;".

> function RemoveAllMessageTags()
>-  for (j = 0; j < tagArray.length; ++j)
>+  for (var j = 0; j < tagArray.length; ++j)

No need to put j into the global scope here.

>+  for (var i = 0; i < selectedMessages.length; ++i)

Nor needs i here.

>+  for (var i = 0; i < selectedMessages.length; ++i)

And here.

>+function PrintEnginePrintInternal(aDoPrintPreview, aMsgType)
>+  if (!messageList) {

Brace on its own line, please.

>+    dump("PrintEnginePrint(): No messages selected.\n");
>+    return false;
>+  }

Also, is the dump really useful? 

> function PrintEnginePrint()
>+  return PrintEnginePrintInternal(false,
>+    Components.interfaces.nsIMsgPrintEngine.MNAB_PRINT_MSG);

No need to wrap, imo.

> function PrintEnginePrintPreview()
>+  return PrintEnginePrintInternal(true,
>+    Components.interfaces.nsIMsgPrintEngine.MNAB_PRINTPREVIEW_MSG);

And here.

r/moa=me with that.

Comment 2

[Ian Neal]

Comment on attachment 680818 [details] [diff] [review]
Remove GSM and refactor other code [Checked in: Comment 2]

https://hg.mozilla.org/comm-central/rev/388b6c8b6ea3

Comment 3

[Philip Chee]

Wed Nov 28 2012 12:56:56
Error: An error occurred updating the cmd_delete command: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.hdrForFirstSelectedMessage]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://messenger/content/folderDisplay.js :: gFolderDisplay.selectedMessage :: line 18"  data: no]
Source file: chrome://global/content/globalOverlay.js
Line: 81
 ----------
Wed Nov 28 2012 12:56:56
Error: An error occurred updating the button_junk command: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.hdrForFirstSelectedMessage]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://messenger/content/folderDisplay.js :: gFolderDisplay.selectedMessage :: line 18"  data: no]
Source file: chrome://global/content/globalOverlay.js
Line: 81
 ----------
Wed Nov 28 2012 12:56:56
Error: An error occurred updating the button_delete command: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.hdrForFirstSelectedMessage]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://messenger/content/folderDisplay.js :: gFolderDisplay.selectedMessage :: line 18"  data: no]
Source file: chrome://global/content/globalOverlay.js
Line: 81
 ----------
Wed Nov 28 2012 12:50:57
Error: ReferenceError: ILPrefs is not defined
Source file: chrome://infolister/content/overlay.js
Line: 37