509324 - Port the thread pane / folder display refactoring from bug 474701 to SeaMonkey

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Robert Kaiser]

Bug 474701 did a large refactoring of the "folder display layer" code, providing an API for the stuff inside what's displayed as a "folder", i.e. inside the thread pane that according to the Thunderbird people is much better to work with than what was used before and still is in use in SeaMonkey.

We should get that ported to SeaMonkey for getting a more consistent API with Thunderbird again and for extension interoperability (note that Lightning is now looking for gFolderDisplay.selectedMessage which errors out in SeaMonkey).

Comment 1

[Serge Gautherie (:sgautherie)]

Here is bug 474701 status wrt SeaMonkey:

It has 3 blocking bugs:
bug 481824: fixed, mailnews. (Already common.)
bug 495327: open, gloda, no patch yet. (Nothing to port (yet))
bug 501161: fixed, mailnews. (Already common.)

It has 5 patches:
attachement 361594: mail, may need porting!?
attachement 375778: mailnews. (Already common.)
attachement 375779: mailnews. (Already common.)
attachement 382997: mail part needs porting. <== That's the (big) one!
attachement 384591: gloda, mail part may need porting (later).

Comment 2

[Robert Kaiser]

(In reply to comment #1)
> attachement 382997: mail part needs porting. <== That's the (big) one!

Yes, porting attachment 382997 [details] [diff] [review] is what I meant for this bug for. I haven't looked at attachment 361594 [details] [diff] [review] - I was naive enough to think that bug had only two patches, the "folder display layer" (API refactoring of thread pane etc.) and the "gloda layer".

Comment 3

[Robert Kaiser]

OK, sorry for two comments in a row, but I just looked at attachment 361594 [details] [diff] [review] and it's just gloda-specific stuff. We might want it, but we should address it in a bug about porting gloda frontend stuff (search, pref UI), and that's not much of a priority right now, as with the bug here fixed and attachment 382997 [details] [diff] [review] ported, it should be possible to provide gloda search with an add-on as all the backend support should already be there and the "folder display layer" should provide the API to hook it into.

Comment 4

[Sander]

For reference, this (together with bug 507601 / bug 510793?) is probably what the enigmail nightly download page - http://enigmail.mozdev.org/download/nightly.php - refers to when it says "Due to recent API changes in Thunderbird (but not in Seamonkey), the current nightly builds do not work on Seamonkey."

Comment 5

[Ian Neal]

Yes, we would like this if someone can get the work done and tested.

Comment 6

[Ian Neal]

As discussed at SM Status meeting, a halfway house would be implementing the APIs that Lightning and Enigmail require to start with, and developing a full port later.

Comment 7

[Ian Neal]

As posted by Patrick in m.d.a.seamonkey:
As you're probably aware of, Enigmail doesn't work on current SeaMonkey
2.0 builds. The reason is that a number of functions from gFolderDisplay
are used, in particular the following ones:

gFolderDisplay.selectedCount
gFolderDisplay.selectedMessages
gFolderDisplay.selectedMessage
gFolderDisplay.selectedMessageUris
gFolderDisplay.messageDisplay.visible
gFolderDisplay.selectedMessageIsNews
gFolderDisplay.selectedMessageIsImap

I hope these functions can be provided, otherwise it will be difficult
to support SeaMonkey.

Comment 8

[Robert Kaiser]

Not wanted for 2.0 any more at this stage, let's push it to 2.1

Comment 9

[Ian Neal]

(In reply to comment #7)
> gFolderDisplay.selectedCount
> gFolderDisplay.selectedMessages
> gFolderDisplay.selectedMessage
> gFolderDisplay.selectedMessageUris
> gFolderDisplay.messageDisplay.visible
> gFolderDisplay.selectedMessageIsNews
> gFolderDisplay.selectedMessageIsImap
> 
These APIs were covered off by bug 516453 and bug 517238, a full port still needs to be done though.

Comment 10

[Ian Neal]

Turning this into a meta bug to track the progress.