811263 - Applying background theme causes Downloads button to jump around

Status: VERIFIED FIXED

Description

[Simona Badau [Away. Please needinfo? Alin Deac [:alindeac]]]

Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/19.0 Firefox/19.0
Build ID: 20121112030753

When applying background themes - the Downloads button jumps around to the most right position on the navigation toolbar. 

Reproducible: always

Steps to reproduce:
1. Launch Firefox with a new profile
2. Navigate a to https://addons.mozilla.org/en-US/firefox/personas/
3. Click on one of the personas -> select the button Add to Firefox
4. After the first background persona is applied, choose a different persona and select the button Add to Firefox.

Expected results:
The background theme is applied and the Download buttons maintain it's position.

Actual results:
After selecting the second persona the Downloads button jumps to the right-most position on the navigation toolbar. After clicking on it the button jumps back to the original position.

Please see the screencast: http://screencast.com/t/LRONYRgQTE

Comment 1

[Marco Bonardo [::mak]]

see bug 803546 for a fix that solved the same issue during Personas preview, could even be the "move to a safe position" change is now causing this.

Comment 2

[Marco Bonardo [::mak]]

Mano said will take a look at this

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Yoinking this bug.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Created attachment 687276 [details] [diff] [review]
Patch v1

There's a pretty complicated tale on this one. Suffice it to say that this is important:

https://bugzilla.mozilla.org/show_bug.cgi?id=585946#c13

And that the social-toolbar-item is not supposed to be customizable, but doesn't have this attribute. This is what was causing the button to flip around when applying lightweight themes with a fresh profile (where the nav-bar's currentset attribute was blank).

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 687276 [details] [diff] [review]
Patch v1

This appears to fix the case that's outlined in the STR. I tried a few variations, and couldn't get the same bug to surface after applying the patch.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/3d1c2eec5a9b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d1c2eec5a9b

Comment 8

[Simona Badau [Away. Please needinfo? Alin Deac [:alindeac]]]

Verified as fixed on the latest Nightly - the downloads button does not jump around after applying background themes.

Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121202 Firefox/20.0
Build ID: 20121202030723