Closed
Bug 811263
Opened 8 years ago
Closed 8 years ago
Applying background theme causes Downloads button to jump around
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
VERIFIED
FIXED
Firefox 20
People
(Reporter: simona.marcu, Assigned: mconley)
References
Details
Attachments
(1 file)
1.08 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/19.0 Firefox/19.0 Build ID: 20121112030753 When applying background themes - the Downloads button jumps around to the most right position on the navigation toolbar. Reproducible: always Steps to reproduce: 1. Launch Firefox with a new profile 2. Navigate a to https://addons.mozilla.org/en-US/firefox/personas/ 3. Click on one of the personas -> select the button Add to Firefox 4. After the first background persona is applied, choose a different persona and select the button Add to Firefox. Expected results: The background theme is applied and the Download buttons maintain it's position. Actual results: After selecting the second persona the Downloads button jumps to the right-most position on the navigation toolbar. After clicking on it the button jumps back to the original position. Please see the screencast: http://screencast.com/t/LRONYRgQTE
Reporter | ||
Updated•8 years ago
|
Blocks: ReleaseDownloadsPane
Comment 1•8 years ago
|
||
see bug 803546 for a fix that solved the same issue during Personas preview, could even be the "move to a safe position" change is now causing this.
Assignee | ||
Comment 4•8 years ago
|
||
There's a pretty complicated tale on this one. Suffice it to say that this is important: https://bugzilla.mozilla.org/show_bug.cgi?id=585946#c13 And that the social-toolbar-item is not supposed to be customizable, but doesn't have this attribute. This is what was causing the button to flip around when applying lightweight themes with a fresh profile (where the nav-bar's currentset attribute was blank).
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 687276 [details] [diff] [review] Patch v1 This appears to fix the case that's outlined in the STR. I tried a few variations, and couldn't get the same bug to surface after applying the patch.
Attachment #687276 -
Flags: review?(mak77)
Updated•8 years ago
|
Attachment #687276 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/3d1c2eec5a9b
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d1c2eec5a9b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Reporter | ||
Comment 8•8 years ago
|
||
Verified as fixed on the latest Nightly - the downloads button does not jump around after applying background themes. Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121202 Firefox/20.0 Build ID: 20121202030723
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•