811392 - Work - Choose better background colors for location text in the Firefox app bar

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Matt Brubeck (:mbrubeck)]

Define the background color of URL text. currently there are two blue colors (one is the text field press-down state, the other is URL text  selection), but the colors don't work with each other very well...  screenshot: http://cl.ly/image/2e1U0Q030e2M

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Location Bar Text Selection

The background-color of the selected text should be #ff8000 and the text should be white. The background-color and the focused border should match.

See mockup here: http://people.mozilla.com/~shorlander/files/metro/metro-infobars-mockup-01.html

Comment 2

[Stephen Horlander [:shorlander]]

Should also note that we should not have the text field press-down state, just the text selection color

Comment 3

[Jonathan Wilde [:jwilde]]

This bug seems to only cover the URL bar. I'll go ahead and patch that in this bug.

What sorts of selection/focus styling should we apply to the rest of the text boxes in the application?

Comment 4

[Jonathan Wilde [:jwilde]]

Attachment: patch v1

Patch just for the urlbar field.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 764500 [details] [diff] [review]
patch v1

Review of attachment 764500 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it! :D

Stephen, is the border width of 2px (which we didn't change) correct?

Comment 6

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1885bc168943

Comment 7

[Ed Morley [:emorley]]

Backed out since the patch on which I believe this relies (bug 873251 comment 11) has also been backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bef2efa89087

Comment 8

[Jonathan Wilde [:jwilde]]

Relanding since it doesn't appear to actually rely on Frank's patch like we previously thought:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f3461e66694

Comment 9

[Stephen Horlander [:shorlander]]

(In reply to Frank Yan (:fryn) from comment #5)
> Stephen, is the border width of 2px (which we didn't change) correct?

Yes. Thanks!

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6f3461e66694