Closed Bug 811413 Opened 8 years ago Closed 8 years ago

Story - Domain highlighting

Categories

(Tracking Graveyard :: Metro Operations, defect, P3)

All
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: jwilde)

References

Details

(Keywords: platform-parity, sec-want, ux-visual-hierarchy, Whiteboard: feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=1)

Attachments

(5 files)

To make it easier for users to determine which site they are viewing (e.g. for security/anti-phishing purposes), we should make the "base domain" darker than the rest of the URL in the location bar.  This should match the UI of desktop Firefox (bug 451833).
Whiteboard: [metro-mvp?][LOE:1] → [metro-mvp?][LOE:1][metro-it1]
Whiteboard: [metro-mvp?][LOE:1][metro-it1] → [metro-mvp?][LOE:1][metro-it2]
Whiteboard: [metro-mvp?][LOE:1][metro-it2] → [metro-mvp][LOE:1][metro-it2]
Blocks: 831671
Summary: Highlight the domain in the Metro location bar by making it darker than surrounding text → Story - Domain highlighting
Whiteboard: [metro-mvp][LOE:1][metro-it2] → [metro-mvp][LOE:1][metro-it2] feature=story u=metro_firefox_user c=navigation_app_bar_and_autocomplete
removing sec-review? - no review needed here as we already looked at this
Flags: sec-review?
Component: Browser → General
Priority: -- → P2
Whiteboard: [metro-mvp][LOE:1][metro-it2] feature=story u=metro_firefox_user c=navigation_app_bar_and_autocomplete → feature=story u=metro_firefox_user c=navigation_app_bar_and_autocomplete p=0
Whiteboard: feature=story u=metro_firefox_user c=navigation_app_bar_and_autocomplete p=0 → feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=0
Priority: P2 → P3
Depends on: 772309
Duplicate of this bug: 772309
Blocks: metrov1planning
No longer blocks: metrov1backlog
Component: General → Metro Operations
Product: Firefox for Metro → Tracking
Version: unspecified → ---
Matt can you provide a point value for this story?
Whiteboard: feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=0 → feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=3
I personally think this should be moved out of v1.
(In reply to Brian R. Bondy [:bbondy] from comment #5)
> I personally think this should be moved out of v1.

I think we should have this. Is there a reason you think we should move it out of v1?
Hi Asa, please see comments #5 and #6.
Flags: needinfo?(asa)
(In reply to Stephen Horlander from comment #6)
> (In reply to Brian R. Bondy [:bbondy] from comment #5)
> > I personally think this should be moved out of v1.
> 
> I think we should have this. Is there a reason you think we should move it
> out of v1?

Yes. I think 99.9% of the people will never know this feature even exists and it's better to have a browser out sooner that is Metro capable than it is to have a feature people won't know exists. I know the decision is not mine though so I'm fine with keeping it in v1 if others want it.
This feature is scheduled for v1 because it's important to help users know what site they're at and this need is even more critical when the address is most of the time hidden off-screen.  For the full screen user, we need to make sure that the address in the transient app toolbar is really easy to read really quickly.  If this were desktop Firefox, I'd be OK with letting this slide out for years (we did) but in Metro I think it's considerably more important. It's not more important than a lot of other things we've got on our todo list, but it is important so I want to try to hold onto it.
Flags: needinfo?(asa)
Sounds good. By the way I didn't even know this existed in desktop Firefox until today.
Blocks: metrov1backlog
No longer blocks: metrov1planning
Blocks: metrobacklog
No longer blocks: 831671, metrov1backlog, 747786
Whiteboard: feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=3 → feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=0
Priority: P3 → P5
Assignee: nobody → hello
Attached patch patch v1Splinter Review
Straight port of what's in desktop Firefox, with modifications to make it cleanly fit into BrowserUI and not dump too much stuff into the autocomplete.xml XBL binding.
p=1
Comment on attachment 762333 [details] [diff] [review]
patch v1

Review of attachment 762333 [details] [diff] [review]:
-----------------------------------------------------------------

Not high priority to review and land at the moment, but more or less done.
Attachment #762333 - Flags: review?(fyan)
Blocks: metrov1it9
No longer blocks: metrobacklog
Status: NEW → ASSIGNED
QA Contact: jbecerra
Whiteboard: feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=0 → feature=story u=metro_firefox_user c=firefox_app_bar_and_autocomplete p=1
Priority: P5 → P3
Comment on attachment 762333 [details] [diff] [review]
patch v1

Review of attachment 762333 [details] [diff] [review]:
-----------------------------------------------------------------

It seems to me that all the code in browser-ui.js should be moved into autocomplete.xml, especially since we keep referring to this._edit in browser-ui.js, which is the element to which autocomplete.xml is bound.
To reflect more clearly that autocomplete.xml is a singleton only used for the urlbar, we could rename the file and the binding ID.

These architectural changes are not urgent, so they don't block this, but perhaps we could do them when we implement the translucent autocomplete panel.

::: browser/metro/base/content/bindings/autocomplete.xml
@@ +41,5 @@
> +
> +      <method name="formatValue">
> +        <body>
> +          <![CDATA[
> +            BrowserUI._formatURI();

This should be "public", i.e. BrowserUI.formatURI();

::: browser/metro/base/content/browser-ui.js
@@ +1029,4 @@
>      }
>      return this._sslDiskCacheEnabled;
>    },
> +  

Nit: blank line.
Attachment #762333 - Flags: review?(fyan) → review+
https://hg.mozilla.org/mozilla-central/rev/8bce22008b25
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
>+          case "browser.urlbar.formatting.enabled":
>+            this._formattingEnabled = Services.prefs.getBookPref(aData);
getBookPref?
(In reply to Philip Chee from comment #17)
> >+          case "browser.urlbar.formatting.enabled":
> >+            this._formattingEnabled = Services.prefs.getBookPref(aData);
> getBookPref?

Good catch! Jonathan fixed that in a later push. :)
QA Contact: jbecerra → srgohilgnfc
Tested on Windows 8 using latest nightly built from  http://hg.mozilla.org/mozilla-central/rev/bc569033125a

Steps:
Opened Firefox nightly in Windows 8 in metro mode and regular mode.
Tried to write google in location bar for both.
google was highlighted in regular mode with same color as Firefox, but not in metro mode. 
I can not understand how highlight works in Metro Firefox. I have attached screen shot for more deatail.
Flags: needinfo?(mbrubeck)
Attached image Metro Firefox
Attached image Regular Firefox
This is strictly about domain highlighting within the address, which shows up after you navigate to a site. 

STR:

1) type google.com (return)
2) after the page navigates, swipe to bring up the navbar

result: you should see a lightened 'www.' + dark 'google.com'.

Locally this works for me.
Flags: needinfo?(mbrubeck)
(In reply to Jim Mathies [:jimm] from comment #23)
> This is strictly about domain highlighting within the address, which shows
> up after you navigate to a site. 
> 
> STR:
> 
> 1) type google.com (return)
> 2) after the page navigates, swipe to bring up the navbar
> 
> result: you should see a lightened 'www.' + dark 'google.com'.
> 
> Locally this works for me.

Thanks Jim.

I tested on Windows 8 using latest nightly built from  http://hg.mozilla.org/mozilla-central/rev/bc569033125a

STR:
1) type google.com (return)
2) after the page navigates, swipe to bring up the navbar.

Actual result:
I see lightened 'www.' + dark 'google.com' which is expected. Please see attached pic.
Status: RESOLVED → VERIFIED
Tested this for iteration 9.
WFM for latest nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013-07-01-mozilla-central-debug
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130807030216
Built from http://hg.mozilla.org/mozilla-central/rev/1fb5d14e8348

WFM
Tested on windows 8 using latest nightly for iteration-11. Followed steps provided in user story and got expected result.
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and got expected result.
OS: Windows 8 Metro → Windows 8.1
Product: Tracking → Tracking Graveyard
You need to log in before you can comment on or make changes to this bug.