Closed
Bug 811414
Opened 12 years ago
Closed 12 years ago
nsISettingsServiceCallback shouldn't use [implicit_jscontext]
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
People
(Reporter: bholley, Assigned: gwagner)
References
Details
Attachments
(2 files, 1 obsolete file)
10.24 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
2.58 KB,
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
If they're implement in JS, we don't support [implicit_jscontext] or [optional_arg]. We can use the JS context stack here.
Reporter | ||
Updated•12 years ago
|
Summary: nsISettingsService and friends shouldn't use [implicit_jscontext] → nsISettingsServiceCallback shouldn't use [implicit_jscontext]
Assignee | ||
Comment 1•12 years ago
|
||
Let's hope it's that simple.
Assignee | ||
Updated•12 years ago
|
Assignee: bobbyholley+bmo → anygregor
Assignee | ||
Comment 2•12 years ago
|
||
Try build: https://tbpl.mozilla.org/?tree=Try&rev=0f1f47b59b9c
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Reporter | ||
Comment 3•12 years ago
|
||
Awesome, thanks gregor! FWIW you can just use nsContentUtils::GetCurrentJSContext() and nsContentUtils::GetSafeJSContext.
Reporter | ||
Comment 4•12 years ago
|
||
Looks like there was some compile nastiness with the thread context stack stuff. Try just including "nsContentUtils.h" and using nsContentUtils::GetCurrentJSContext().
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #4) > Looks like there was some compile nastiness with the thread context stack > stuff. Try just including "nsContentUtils.h" and using > nsContentUtils::GetCurrentJSContext(). Yes I did another try run earlier with some fixes: https://tbpl.mozilla.org/?tree=Try&rev=ec51cc01c3ca
Reporter | ||
Comment 6•12 years ago
|
||
Nice! Some comments: Please rev the IID on nsISettingsServiceCallback. Just use NS_ENSURE_TRUE(cx, NS_OK) to check the safe JS context. You need to enter the compartment of aResult before creating the dependent string.
Updated•12 years ago
|
blocking-basecamp: ? → +
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #681232 -
Attachment is obsolete: true
Attachment #681608 -
Flags: review?(bobbyholley+bmo)
Reporter | ||
Comment 8•12 years ago
|
||
Comment on attachment 681608 [details] [diff] [review] patch Review of attachment 681608 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=bholley
Attachment #681608 -
Flags: review?(bobbyholley+bmo) → review+
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f4b5d48c73
Assignee | ||
Comment 10•12 years ago
|
||
Huh B2G doesn't start any more. Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/b809cfffa5f7
Assignee | ||
Comment 11•12 years ago
|
||
Assignee | ||
Comment 12•12 years ago
|
||
Comment on attachment 681676 [details] [diff] [review] followup r=mrbkap standing right next to me
Attachment #681676 -
Flags: review+
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65a144464450 https://hg.mozilla.org/integration/mozilla-inbound/rev/369fe18f5a45
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/369fe18f5a45 https://hg.mozilla.org/mozilla-central/rev/65a144464450
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment 15•12 years ago
|
||
This is marked as blocking-basecamp+ but doesn't apply cleanly to Aurora due to it not having dom/system/gonk/TimeZoneSettingObserver.cpp. Please either post a branch-specific patch or let me know if it's OK to just ignore the changes to that file.
Assignee | ||
Comment 16•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #15) > This is marked as blocking-basecamp+ but doesn't apply cleanly to Aurora due > to it not having dom/system/gonk/TimeZoneSettingObserver.cpp. Please either > post a branch-specific patch or let me know if it's OK to just ignore the > changes to that file. Good question. Let's ask cjones if we want dom/system/gonk/TimeZoneSettingObserver.cpp in aurora.
Flags: needinfo?(jones.chris.g)
Reporter | ||
Comment 17•12 years ago
|
||
Can we get this landed on aurora? the branch is almost here.
(In reply to Gregor Wagner [:gwagner] from comment #16) > (In reply to Ryan VanderMeulen from comment #15) > > This is marked as blocking-basecamp+ but doesn't apply cleanly to Aurora due > > to it not having dom/system/gonk/TimeZoneSettingObserver.cpp. Please either > > post a branch-specific patch or let me know if it's OK to just ignore the > > changes to that file. > > Good question. Let's ask cjones if we want > dom/system/gonk/TimeZoneSettingObserver.cpp in aurora. What is this fellow? Why isn't it on aurora already?
Flags: needinfo?(jones.chris.g)
Assignee | ||
Comment 19•12 years ago
|
||
(In reply to Chris Jones [:cjones] [:warhammer] from comment #18) > (In reply to Gregor Wagner [:gwagner] from comment #16) > > (In reply to Ryan VanderMeulen from comment #15) > > > This is marked as blocking-basecamp+ but doesn't apply cleanly to Aurora due > > > to it not having dom/system/gonk/TimeZoneSettingObserver.cpp. Please either > > > post a branch-specific patch or let me know if it's OK to just ignore the > > > changes to that file. > > > > Good question. Let's ask cjones if we want > > dom/system/gonk/TimeZoneSettingObserver.cpp in aurora. > > What is this fellow? Why isn't it on aurora already? It's bug 792290 and it was not marked as blocking-basecamp.
Comment 20•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/af6d073474d1 https://hg.mozilla.org/releases/mozilla-aurora/rev/4ab2a011cbaf
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•