Closed Bug 813278 Opened 13 years ago Closed 13 years ago

JSVAL_TO_OBJECT called on string in TimeZoneSettingObserver

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-basecamp +
Tracking Flags:
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file)

patch
4.13 KB, patch
luke
: review+
Details | Diff | Splinter Review
This asserts and crashes in DEBUG builds, and should not be done. I am told JSStrings are not JSObjects.
Depends on: 811414
Attached patch patch — — Splinter Review
Add an overload for JSAutoCompartment for JSString and use it.
Attachment #683282 - Flags: review?(bobbyholley+bmo)
Comment on attachment 683282 [details] [diff] [review] patch Seems fine to me, but bouncing to luke just in case.
Attachment #683282 - Flags: review?(bobbyholley+bmo) → review?(luke)
Attachment #683282 - Flags: review?(luke) → review+
Blocks: 716859
https://hg.mozilla.org/integration/mozilla-inbound/rev/26544b27ef13
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/26544b27ef13
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
blocking-basecamp: --- → ?
Basecamp blocking which needs to be merged into Aurora and Beta.
blocking-basecamp: ? → +
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: