811738 - Close tab tray after closing last tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Closing the last tab returns us to about:home (bug 786982), but leaves the tab tray open. We should close the tray at the same time, so people can start using about:home right away.

Comment 1

[Ian Barlow (:ibarlow)]

To elaborate a bit here, let's try to simplify the transition as well. Closing the last tab and then showing the about:home tab before doing anything feels strange too. The transition should happen as follows.

1. Close last tab
2. Close tabs tray onto blank blue background
3. Slide or fade in about:home content.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This hides the tabs-tray on closing the last tab.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 686339 [details] [diff] [review]
Patch

Worth seeing how this feels

Comment 4

[Lucas Rocha (:lucasr)]

Drive-by: does this patch ensure that the new about:home tab is now shown before the slide animation finishes? It won't look good if you see a tab being re-added while closing the tabs tray.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Yup it does. Once you tap on the close button (or swipe), that animation starts. And even before that ends, the tabs-tray would have been hidden and switched to about:home.

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/210a6a177031

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/210a6a177031

Comment 8

[Cristian Nicolae (:xti)]

Tabs Tray is closed after the last tab is closed. 

--
Firefox 20.0a1 (2012-12-06)
Device: Galaxy Tab2 7"
OS: Android 4.0.3

Comment 9

[Ioana Chiorean]

TCs added in Moztrap with new option for following versions: 20 , 20 tablets 

https://moztrap.mozilla.org/manage/case/5883 - Tab tray is close after closing last tab