Don't use a temporary surface for inactive opacity surfaces if we don't need to

NEW
Unassigned

Status

()

Core
Layout
5 years ago
5 years ago

People

(Reporter: mattwoodrow, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy:p1][leave open])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 681724 [details] [diff] [review]
Skip PushGroup if we can

We do this a lot when painting gmail, this *should* help with performance there a fair bit.
Attachment #681724 - Flags: review?(roc)
(Reporter)

Comment 1

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=e407ac327723


I realise that there are a lot more display item types that could probably return false here, we should do that as a followup.
Comment on attachment 681724 [details] [diff] [review]
Skip PushGroup if we can

Review of attachment 681724 [details] [diff] [review]:
-----------------------------------------------------------------

I think this prevents opacity from being applied at all.

I suggest turning these layers into ImageLayers.
(Reporter)

Comment 3

5 years ago
Created attachment 682270 [details] [diff] [review]
Convert background images to ImageLayers

This is simple and worth having.

I have a WIP patch that fixes the other patch in this bug. It works, but needs a lot of tidying up.
Attachment #682270 - Flags: review?(roc)
(Reporter)

Updated

5 years ago
Attachment #681724 - Attachment is obsolete: true
Attachment #681724 - Flags: review?(roc)
Attachment #682270 - Flags: review?(roc) → review+

Updated

5 years ago
Whiteboard: [Snappy:p1]
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/526896647e96
Whiteboard: [Snappy:p1] → [Snappy:p1][leave open]
https://hg.mozilla.org/mozilla-central/rev/526896647e96
Depends on: 816692
You need to log in before you can comment on or make changes to this bug.