Open Bug 811927 Opened 8 years ago Updated 8 years ago

Don't use a temporary surface for inactive opacity surfaces if we don't need to

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set
normal

Tracking

()

People

(Reporter: mattwoodrow, Unassigned)

References

Details

(Whiteboard: [Snappy:p1][leave open])

Attachments

(1 file, 1 obsolete file)

Attached patch Skip PushGroup if we can (obsolete) — Splinter Review
We do this a lot when painting gmail, this *should* help with performance there a fair bit.
Attachment #681724 - Flags: review?(roc)
https://tbpl.mozilla.org/?tree=Try&rev=e407ac327723


I realise that there are a lot more display item types that could probably return false here, we should do that as a followup.
Comment on attachment 681724 [details] [diff] [review]
Skip PushGroup if we can

Review of attachment 681724 [details] [diff] [review]:
-----------------------------------------------------------------

I think this prevents opacity from being applied at all.

I suggest turning these layers into ImageLayers.
This is simple and worth having.

I have a WIP patch that fixes the other patch in this bug. It works, but needs a lot of tidying up.
Attachment #682270 - Flags: review?(roc)
Attachment #681724 - Attachment is obsolete: true
Attachment #681724 - Flags: review?(roc)
Whiteboard: [Snappy:p1]
https://hg.mozilla.org/integration/mozilla-inbound/rev/526896647e96
Whiteboard: [Snappy:p1] → [Snappy:p1][leave open]
Depends on: 816692
You need to log in before you can comment on or make changes to this bug.