811927 - Don't use a temporary surface for inactive opacity surfaces if we don't need to

Status: NEW

(Core :: Layout, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Skip PushGroup if we can

We do this a lot when painting gmail, this *should* help with performance there a fair bit.

Comment 1

[Matt Woodrow (:mattwoodrow)]

https://tbpl.mozilla.org/?tree=Try&rev=e407ac327723


I realise that there are a lot more display item types that could probably return false here, we should do that as a followup.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 681724 [details] [diff] [review]
Skip PushGroup if we can

Review of attachment 681724 [details] [diff] [review]:
-----------------------------------------------------------------

I think this prevents opacity from being applied at all.

I suggest turning these layers into ImageLayers.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Convert background images to ImageLayers

This is simple and worth having.

I have a WIP patch that fixes the other patch in this bug. It works, but needs a lot of tidying up.

Comment 4

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/526896647e96

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/526896647e96