Last Comment Bug 811927 - Don't use a temporary surface for inactive opacity surfaces if we don't need to
: Don't use a temporary surface for inactive opacity surfaces if we don't need to
Status: NEW
[Snappy:p1][leave open]
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal with 3 votes (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on: 816692
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 15:02 PST by Matt Woodrow (:mattwoodrow)
Modified: 2012-12-04 07:00 PST (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Skip PushGroup if we can (10.42 KB, patch)
2012-11-14 15:02 PST, Matt Woodrow (:mattwoodrow)
no flags Details | Diff | Splinter Review
Convert background images to ImageLayers (15.78 KB, patch)
2012-11-15 16:48 PST, Matt Woodrow (:mattwoodrow)
roc: review+
Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2012-11-14 15:02:28 PST
Created attachment 681724 [details] [diff] [review]
Skip PushGroup if we can

We do this a lot when painting gmail, this *should* help with performance there a fair bit.
Comment 1 Matt Woodrow (:mattwoodrow) 2012-11-14 15:05:57 PST
https://tbpl.mozilla.org/?tree=Try&rev=e407ac327723


I realise that there are a lot more display item types that could probably return false here, we should do that as a followup.
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2012-11-14 17:05:00 PST
Comment on attachment 681724 [details] [diff] [review]
Skip PushGroup if we can

Review of attachment 681724 [details] [diff] [review]:
-----------------------------------------------------------------

I think this prevents opacity from being applied at all.

I suggest turning these layers into ImageLayers.
Comment 3 Matt Woodrow (:mattwoodrow) 2012-11-15 16:48:45 PST
Created attachment 682270 [details] [diff] [review]
Convert background images to ImageLayers

This is simple and worth having.

I have a WIP patch that fixes the other patch in this bug. It works, but needs a lot of tidying up.
Comment 4 Matt Woodrow (:mattwoodrow) 2012-11-18 19:29:01 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/526896647e96
Comment 5 Ed Morley [:emorley] 2012-11-19 07:38:27 PST
https://hg.mozilla.org/mozilla-central/rev/526896647e96

Note You need to log in before you can comment on or make changes to this bug.