Closed Bug 816692 Opened 12 years ago Closed 12 years ago

"Undo Close group" option of panorama: Close icon broken.

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20

People

(Reporter: u443210, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

issue.png
37.25 KB, image/png
Details
Use the correct imgIContainer
1.57 KB, patch
roc
: review+
Details | Diff | Splinter Review
Attached image issue.png — 
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:20.0) Gecko/20121129 Firefox/20.0
Build ID: 20121129074803

Steps to reproduce:

_Open firefox.
_Go to panorama.
_Open a new group with 1 o more tabs.
_Close this group.


Actual results:

The "x" icon of the "Undo close Group" is broken.
Component: Untriaged → Panorama
Keywords: regressionwindow-wanted
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Last good nightly: 2012-11-19
First bad nightly: 2012-11-20

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4fddb9923ef0&tochan
ge=bc69705c162d

Caused by bug 811927 (used tinderbox builds)
Blocks: 811927
Keywords: regressionwindow-wanted
Component: Panorama → Layout
Product: Firefox → Core
Assignee: nobody → matt.woodrow
nsImageRenderer sets up a cropped imgIContainer in mImageContainer, and then we ignore that and retrieve the original, uncropped one.

This meant that we were taking the entire sprite sheet and scaling it down to the size of an individual image. Not a good look.
Attachment #688540 - Flags: review?(joe)
Sorry for the delay; I was ill last week!
https://hg.mozilla.org/mozilla-central/rev/bb0dbeb26f1d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: