812024 - [socorro-crashstats] Exception Type: TypeError at /daily Exception Value: 'versions' is a required parameter

Status: RESOLVED WONTFIX

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://crash-stats-new-dev.allizom.org/daily?form_selection=by_version&p=Camino&v=&hang_type=hang-p&os=Mac+OS+X&date_range_type=report&date_start=2012-10-31&date_end=2012-11-14 throws the following:

    Traceback:
    File "/home/rhelmer/src/socorro-crashstats/vendor/lib/python/django/core/handlers/base.py" in get_response
      111.                         response = callback(request, *callback_args, **callback_kwargs)
    File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in inner
      155.         return view(request, *args, **kwargs)
    File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in daily
      466.         report_type=hang_type
    File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in get
      335.                 raise TypeError("%r is a required parameter" % param)
     
    Exception Type: TypeError at /daily
    Exception Value: 'versions' is a required parameter

Comment 1

[Robert Helmer [:rhelmer]]

So the problem here is that if no versions are specified, then the view attempts to fallback to the current featured versions. However Camino has no featured versions :(

I had not filtered out Camino here since I thought maybe it'd be valuable to be able to pick old products with no current releases, but perhaps we should just filter out products with no current releases, just as we do for the product/version selectors at the top of each page...

Comment 2

[Robert Helmer [:rhelmer]]

In prod this just has no selectable versions:

https://crash-stats.mozilla.com/daily?p=Camino&v[]=

I think we should just hide releases with no current releases.

Comment 3

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/292

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/240c3f3a280bd049c917939a8cea1c9e8ef240c0
bug 812024 - only show current versions in /daily product pulldown

https://github.com/mozilla/socorro-crashstats/commit/2421480e1cc78c52b6f92417ee9d4335934d8b3e
Merge pull request #292 from rhelmer/bug812024-filter-out-expired-versions-from-daily

bug 812024 - only show current versions in /daily product pulldown

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Fix didn't fix the original issue in comment 0; reopening :-)

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Stephen Donner [:stephend] from comment #5)
> Fix didn't fix the original issue in comment 0; reopening :-)

Hmmm... true, but it no longer shows up in the menus so it's not possible to select it :P

I agree we should not 500 here, I am going to unblock staging though.

Comment 7

[Robert Helmer [:rhelmer]]

Not actively working on this

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

FWIW, this happens, still, as follows:

https://crash-stats.allizom.org/daily?p=Camino

https://errormill.mozilla.org/webtools/socorro-stage/group/96989/

Comment 9

[Peter Bengtsson [:peterbe]]

The old /daily report is deprecated.