812050 - [modern] some dialog boxes clipped at the bottom. Need to add commonDialog.css to Modern.

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect)

Description

[Rich Gray (:rbgray)]

Attachment: clipped Master Password dialog box (at startup)

Starting with the 2.14 betas, certain dialog boxes (but not all) are clipped at the bottom edge.  The edge of the dialog box cuts off the lower edge of the buttons in the box.

Possible dup of bug 280909 but this just started.

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Firefox/17.0 SeaMonkey/2.14
Build identifier: 20121108003404

Comment 1

[Rich Gray (:rbgray)]

Attachment: clipped browser windows close confirm dialog

Comment 2

[Rich Gray (:rbgray)]

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Firefox/17.0 SeaMonkey/2.14
    Build identifier: 20121113154231

Strangely, under 2.14b5, the browser close confirm window no longer clips, but the master password window is still clipped.

Comment 4

[Rich Gray (:rbgray)]

Phillip, here be screenshots. 

Still seeing this in 2.15b1.  Also, the browser close confirm window is now clipping again...

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:18.0) Gecko/18.0 Firefox/18.0 SeaMonkey/2.15
Build identifier: 20121125145905

Also just confirmed in 2.14.1 and 2.17b1 under OS X 10.7.5 Lion.  
Version > trunk, right?

Comment 5

[Tony Mechelynck [:tonymec]]

In reply to comment #4: There is no 2.17b1 yet. SeaMonkey trunk is 2.17a1, the latest (and highest, so far) b1 is the recently released 2.15b1. If you mean you see the problem in 2.17a1, then yes, that means Trunk.

Comment 6

[Rich Gray (:rbgray)]

Thanks, Tony, my mistake.  2.17A1.

Comment 7

[Stefan [:stefanh]]

Modern doesn't seem to have commonDialog.css. Including the pinstripe version fixes the problem. We should probably get us a "Modern" commonDialog.css that looks ok on all OS.

Comment 8

[Stefan [:stefanh]]

In this particular case, it's the #infoContainer in toolkit's commonDialog.css that fixes it.

Comment 9

[Philip Chee]

Possible fallout from either/or:
Bug 625814 - commonDialog icon and text are now differently misaligned (at least on Linux)
Bug 608604 - commonDialog icon and text are misaligned

Comment 10

[David E. Ross]

Is this really a SeaMonkey theme problem?  I see a similar problem in Thunderbird (Default 24.1.0 theme), with the Check Spelling dialogue.

Comment 11

[Daniel]

User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 SeaMonkey/2.22
Build identifier: 20131023190953

I am see this "Clipped Window" occurring on my Win7 SM 2.22, info shown above.

In my case, I am seeing the "Clipped Window" in the Spell-checker window when trying to send a message.

Co-coincidently, maybe, in the Mail & Newsgroup screens Accounts Pane and Threads Pane, the lines of text are extra spaced out, maybe for 16pt or 18pt text. The text actually can be reduced back to 12pt, but the spacing is still spread out, as though the line spacing is still set for the much bigger font size, not reduced for the reduced text size.

Is it at all possible that the "Clipped Window" are having their window size set for 'x' lines of 12pt font, but the lines of text with-in the "Clipped Window" are being set to use the bigger font size lines, so the lines of text are spaced more widely, so having their bottom lines cut off??

Comment 12

[Daniel]

Should have mentioned in Comment 11 that I use the Default theme!

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Daniel from comment #11)
> User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101
> Firefox/25.0 SeaMonkey/2.22
> Build identifier: 20131023190953
> 
> I am see this "Clipped Window" occurring on my Win7 SM 2.22, info shown
> above.
> 
> In my case, I am seeing the "Clipped Window" in the Spell-checker window
> when trying to send a message.

I can confirm this issue, but it's not this bug. Please create a new one for that, attach a screen shot, and CC me. Thanks. [That dialog is totally unrelated to the issue here - same "high level" issue, but needs its own analysis and technical solution. BTW concerning the bug it doesn't matter whether you're trying to send a message or open the dialog just like that.]

> Co-coincidently, maybe, in the Mail & Newsgroup screens Accounts Pane and
> Threads Pane, the lines of text are extra spaced out, maybe for 16pt or 18pt
> text.

That's bug 927779 which I pushed a fix to trunk for yesterday. The next nightly will include it, and if all goes well, SM 2.23 eventually will, too.

> Is it at all possible that the "Clipped Window" are having their window size
> set for 'x' lines of 12pt font, but the lines of text with-in the "Clipped
> Window" are being set to use the bigger font size lines, so the lines of
> text are spaced more widely, so having their bottom lines cut off??

Don't know about this bug here (since it's Mac-specific), but the Check Spelling bug you found is probably related to the height of buttons which I could imagine to be greater now on Win7 due to some platform-specific Toolkit CSS that might have been introduced at some point in time.

Comment 14

[Samiullah]

Hi Rich Gray

I would want to help fix this bug, can you assign it to me please. I will be attempting to fix the bug, thank you.

Comment 15

[Samiullah]

Hi Rich Gray

I would want to help fix this bug, can you assign it to me please. I will be attempting to fix the bug, thank you.

Comment 16

[Rich Gray (:rbgray)]

Sure.  Sadly, real world situations have prevented me from SeaMonkey activity.

Comment 17

[Rich Gray (:rbgray)]

Seems to be healed in Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26.  I think this is beta 1.

Must be a side effect of some other change...  Can anyone else confirm?   Resolve WFM?

Comment 18

[Stefan [:stefanh]]

I don't see this in my trunk debug build. If you don't see this with both an old and a fresh profile, I think you can resolve this as WFM.

Comment 19

[David E. Ross]

Re comment #12 and comment #13:  
I see this problem with SeaMonkey 2.25 and its default theme.  Does this bug report not address the default theme?  Or is a new bug report required?  

Re comment #18:  
I request that this bug report NOT be marked "Works for me" until end-users can install and experience the RELEASED version 2.26.  If it is indeed fixed in 2.26, this bug report should be marked as Fixed before the release of 2.26 only if specific code changes between 2.25 and 2.26 can be identified.

Comment 20

[Stefan [:stefanh]]

(In reply to David E. Ross from comment #19)
> Re comment #12 and comment #13:  
> I see this problem with SeaMonkey 2.25 and its default theme.  Does this bug
> report not address the default theme?  Or is a new bug report required?  

This bug report is/was about an issue in the modern theme (see the keywords field). It's also probably mac-specific, since there have been no reports about this specific issue on other platforms (but the modern theme is the same for all platforms, though). If you have an issue with the default theme, you should file a new bug report.

Comment 21

[Kartik Gautam]

Hi,

Does this bug still exists? I would like to work on this bug, please guide me a little bit as i am it will be my first bug.

Thank You,
Kartik Gautam

Comment 22

[Rich Gray (:rbgray)]

I've not noticed this in ages, but it turns out I wasn't running Modern. Just switched and at first look, I don't see the problem where it previously exhibited in comment 1. (OK, where'd they hide the attachment options???)

Comment 23

[Stefan [:stefanh]]

Kartik, thanks for looking at this :-). But it looks like this bug doesn't exist anymore. I just tested myself and dialog boxes are not clipped at the bottom.

Comment 24

[Stefan [:stefanh]]

Resolving this as WFM.