Closed
Bug 812130
Opened 13 years ago
Closed 13 years ago
Increase the account provisioner timeout to greater than the server timeout
Categories
(Thunderbird :: Account Manager, defect)
Thunderbird
Account Manager
Tracking
(thunderbird18+ fixed, thunderbird-esr1718+ fixed)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: standard8, Assigned: bwinton)
References
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-esr17+
|
Details | Diff | Splinter Review |
The account provisioner timeout on individual providers is 10 seconds (run in async mode), but the server timeout is also 10 seconds.
We should increase Thunderbird's timeout slightly, to say 11 seconds, or maybe just 15 to ensure that even in a timeout situation, Thunderbird will still receive and display results for providers that haven't timed out (as realised in bug 812101).
| Reporter | ||
Updated•13 years ago
|
tracking-thunderbird18:
--- → +
| Assignee | ||
Comment 1•13 years ago
|
||
Untested, but simple enough that I'm quite confident.
Comment 2•13 years ago
|
||
Comment on attachment 682015 [details] [diff] [review]
Change the timeout to 15 seconds.
Review of attachment 682015 [details] [diff] [review]:
-----------------------------------------------------------------
This is correct. Thanks Blake!
Attachment #682015 -
Flags: review?(mconley) → review+
Comment 3•13 years ago
|
||
Landed on comm-central as https://hg.mozilla.org/comm-central/rev/a82b990ea07f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
| Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 682015 [details] [diff] [review]
Change the timeout to 15 seconds.
[Triage Comment]
Lets get this on aurora as well, as I'd like to make it safer for the next releases as well (and we'll get onto esr once that is up and running).
Attachment #682015 -
Flags: approval-comm-aurora+
| Reporter | ||
Comment 5•13 years ago
|
||
Comment on attachment 682015 [details] [diff] [review]
Change the timeout to 15 seconds.
Landed
https://hg.mozilla.org/releases/comm-aurora/rev/367783b7c4a1
Also flagging for next release.
Attachment #682015 -
Flags: approval-comm-esr17?
| Reporter | ||
Updated•13 years ago
|
status-thunderbird18:
--- → fixed
| Reporter | ||
Updated•13 years ago
|
Attachment #682015 -
Flags: approval-comm-esr17? → approval-comm-esr17+
| Reporter | ||
Comment 6•13 years ago
|
||
status-thunderbird-esr17:
--- → fixed
tracking-thunderbird-esr17:
--- → 18+
You need to log in
before you can comment on or make changes to this bug.
Description
•