Home button should not be blocked, except FTU

RESOLVED FIXED in B2G C2 (20nov-10dec)

Status

Firefox OS
Gaia::System
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jcarpenter, Assigned: alive)

Tracking

unspecified
B2G C2 (20nov-10dec)
x86
Mac OS X

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: interaction)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Inline activites should never block the Home button. The entire point of the Home button is that it's an almost-universally reliable "back" button. We may eventually decide to make exceptions to this rule for dialogues (ala iOS), but certainly not for activities.

Blocking. This is broken usability and a mis-application of the spec. Activity-based flows have some severe usability problems in current builds, and this is one of the reasons. The impact stretches from Camera to Email to PDF Viewer.

Per the comments in bug #802494:

>> Inline activity should not block home button press.
> If this is a must-fix behavior in System, > please file a bug, set it blocked by this one, and make sure both are blocking+.
Gaia Triage : This may be a duplicate; gaia triage consensus is though that this is a usability issue, P2.  + for now until a dup is found.
blocking-basecamp: ? → +
Priority: -- → P2
QA Contact: nhirata.bugzilla
Whiteboard: usability → usability, dupme
I can't seem to find the dup.  Closest I came was bug 796780
Whiteboard: usability, dupme → usability
Assignee: nobody → alive
I notice that fullscreen element also blocks the home button.
The only thing that blocks home button now is FTU, is this correct?
Flags: needinfo?(jcarpenter)
(In reply to Alive Kuo [:alive] from comment #3)
> I notice that fullscreen element also blocks the home button.
> The only thing that blocks home button now is FTU, is this correct?

FTU seems a legitime case.
(Reporter)

Comment 5

6 years ago
(In reply to Alive Kuo [:alive] from comment #3)
> I notice that fullscreen element also blocks the home button.
> The only thing that blocks home button now is FTU, is this correct?

That's correct: FTE should block the Home button because it's a special case. 

At one point we discussed having prompts block Home (ala iOS), but decided not to take that approach for v1.
Flags: needinfo?(jcarpenter)
Created attachment 683970 [details]
PR6552

https://github.com/mozilla-b2g/gaia/pull/6552

Make home button not blocked by anything, except FTU.
Attachment #683970 - Flags: review?(timdream+bugs)
Renaming the bug title per #5
Summary: Inline activities must not block Home button → Home button should not be blocked, except FTU
(Reporter)

Comment 8

6 years ago
And lock screen, of course, but that seems pretty obvious.

Comment 9

6 years ago
Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.
Target Milestone: --- → B2G C2 (20nov-10dec)
Comment on attachment 683970 [details]
PR6552

r=me. We have discuss the desired behavior offline. Thanks!
Attachment #683970 - Flags: review?(timdream+bugs) → review+
https://github.com/mozilla-b2g/gaia/pull/6552
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Seems something broken after merging, reverting and reopen.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
After reverting, the problem still happens after ftu running.
I bet something is wrong in ftu. I am going to merge my patch again.
(Reporter)

Updated

6 years ago
Whiteboard: usability → interaction
Assignee: alive → fbsc
(In reply to Alive Kuo [:alive] from comment #13)
> After reverting, the problem still happens after ftu running.
> I bet something is wrong in ftu. I am going to merge my patch again.

I am sorry, I think mistaken this with another bug. Have you merge this patch again? If not please do so (it is still considered r+'d)
Assignee: fbsc → alive
https://github.com/mozilla-b2g/gaia/commit/adfca85f08b55dde18b97d5ac185e13181555c64
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.