"Assertion failure: aDefaultValue <= aMaxValue" with createDelay(NaN)

RESOLVED FIXED in mozilla19

Status

()

Core
Web Audio
--
critical
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: Ehsan)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla19
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 682282 [details]
testcase

Assertion failure: aDefaultValue <= aMaxValue, at ../../../../content/media/webaudio/AudioEventTimeline.h:89

Maybe the test in bug 809882 should be "inverted" so a NaN input takes the early-return branch?
(Reporter)

Comment 1

6 years ago
Created attachment 682283 [details]
stack
(Assignee)

Comment 2

6 years ago
Yeah, makes sense.
(Assignee)

Comment 3

6 years ago
Created attachment 682288 [details] [diff] [review]
Patch (v1)
Attachment #682288 - Flags: review?(bzbarsky)
Comment on attachment 682288 [details] [diff] [review]
Patch (v1)

Maybe add comment in the IDL about this really wanting to be a float, not an unrestricted float, for when we implement those.

r=me with that.
Attachment #682288 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/a1683ba4319d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 7

5 years ago
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.