Closed Bug 812390 Opened 8 years ago Closed 8 years ago

"Assertion failure: aDefaultValue <= aMaxValue" with createDelay(NaN)

Categories

(Core :: Web Audio, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jruderman, Assigned: ehsan)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
Assertion failure: aDefaultValue <= aMaxValue, at ../../../../content/media/webaudio/AudioEventTimeline.h:89

Maybe the test in bug 809882 should be "inverted" so a NaN input takes the early-return branch?
Attached file stack
Yeah, makes sense.
Attached patch Patch (v1)Splinter Review
Attachment #682288 - Flags: review?(bzbarsky)
Comment on attachment 682288 [details] [diff] [review]
Patch (v1)

Maybe add comment in the IDL about this really wanting to be a float, not an unrestricted float, for when we implement those.

r=me with that.
Attachment #682288 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/a1683ba4319d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.