812512 - merge day changes for bug 773120 - remove 10.5 (Leopard) jobs from all of our code

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

Attachment: remove leopard completely

Two versions after 17 we can drop the esr10 code and we can then disable the Leopard tests completely.

Comment 1

[Armen [:armenzg]]

Attachment: remove leopard completely (buildbotcustom)

Comment 2

[Armen [:armenzg]]

Attachment: leopard changes

Comment 3

[Armen [:armenzg]]

Attachment: remove leopard completely (buildbotcustom)

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 715502 [details] [diff] [review]
leopard changes

Review of attachment 715502 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/project_branches.py
@@ +333,5 @@
>          },
>      },
>      'pine': {},
>      'gaia-master': {
> +        'poll_repo': 'integration/gaia-central',

Is this part of a different patch?

Comment 6

[Armen [:armenzg]]

(In reply to Chris Cooper [:coop] from comment #5)
> Comment on attachment 715502 [details] [diff] [review]
> leopard changes
> 
> Review of attachment 715502 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla/project_branches.py
> @@ +333,5 @@
> >          },
> >      },
> >      'pine': {},
> >      'gaia-master': {
> > +        'poll_repo': 'integration/gaia-central',
> 
> Is this part of a different patch?

Yes. I noticed later.

Comment 7

[Armen [:armenzg]]

Attachment: remove leopard (tools)

Comment 8

[Armen [:armenzg]]

Attachment: remove leopard (puppet)

Comment 9

[Chris Cooper [:coop] (he/him)]

Comment on attachment 715532 [details] [diff] [review]
remove leopard (tools)

Review of attachment 715532 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/mobile/setup_foopy.py
@@ +10,5 @@
>  toolsdir = "/builds/tools"
>  path_to_bmm_host = "/builds/bmm.hostname.txt"
>  path_to_manage_buildslave = "/builds/manage_buildslave.sh"
>  # cltbld's uid and gid
> +const_uid=getpwnam('cltbld')[2]

Is there a reason to not preserve the spacing now? Isn't the spacing pep8?

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 715532 [details] [diff] [review]
remove leopard (tools)

Review of attachment 715532 [details] [diff] [review]:
-----------------------------------------------------------------

r- JUST for the inclusion of these two files in this patch

::: buildfarm/mobile/manage_buildslave.sh
@@ -1,1 @@
>  #!/bin/bash

The changes to this file will break clientproxy-less foopies, and sure don't belong lumped in this patch, I suspect it was an oversight.

::: buildfarm/mobile/setup_foopy.py
@@ -6,1 @@
>  

I can't imagine these changes belong in this patch either

Comment 11

[Chris Cooper [:coop] (he/him)]

Comment on attachment 715534 [details] [diff] [review]
remove leopard (puppet)

Review of attachment 715534 [details] [diff] [review]:
-----------------------------------------------------------------

r+, assuming you don't remove talos-r3-snow-NN from test_runslave.py.

::: modules/buildslave/files/test_runslave.py
@@ -180,5 @@
>          't-r3-w764-NN' : 'c:\\talos-slave',
>          'talos-r3-fed-NN' : '/home/cltbld/talos-slave',
>          'talos-r3-fed64-NN' : '/home/cltbld/talos-slave',
> -        'talos-r3-leopard-NN' : '/Users/cltbld/talos-slave',
> -        'talos-r3-snow-NN' : '/Users/cltbld/talos-slave',

Need to keep Snow Leopard.

Comment 12

[Armen [:armenzg]]

Attachment: remove leopard (tools)

I'm sorry about the mess. Dealing with both esr10 removal and leopard removal has been making mess things up.

Comment 13

[Armen [:armenzg]]

Attachment: remove leopard (tools)

Comment 14

[Armen [:armenzg]]

Attachment: wip - leopard changes

I decided to wait on esr10 to land first before I finish this up (as the patches were crossing over each other).

This patch passes test-masters.sh but I have to confirm that we only remove what we need and nothing more.

Comment 15

[Armen [:armenzg]]

Attachment: remove leopard completely (buildbot-configs)

This is a no-op change after landing the removal of esr10.

Comment 16

[Aki Sasaki (not active)]

Comment on attachment 715782 [details] [diff] [review]
remove leopard completely (buildbot-configs)

Looks like we can also kill mozilla2/macosx/ .

Comment 17

[Aki Sasaki (not active)]

Comment on attachment 715782 [details] [diff] [review]
remove leopard completely (buildbot-configs)

http://hg.mozilla.org/build/buildbot-configs/rev/a6380dbe3c67

Comment 18

[Armen [:armenzg]]

Live in production.