The default bug view has changed. See this FAQ.

When hovering over the Menu Button, hover text is: "Displays the Application Menu"

RESOLVED FIXED in Thunderbird 20.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rolandtanglao, Assigned: Paenglab)

Tracking

17 Branch
Thunderbird 20.0
x86_64
Windows 8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
IRC :bwinton suggested this hover text is wrong. Perhaps it should be "Display the Thunderbird menu" or some such?
(Assignee)

Comment 1

4 years ago
Yeah, this would be better.

Isn't this a little bit to late for TB 17? Could this land with the translations in the next 17.0.x build?
(Reporter)

Comment 2

4 years ago
(In reply to Richard Marti [:Paenglab] from comment #1)
> Yeah, this would be better.
> 
> Isn't this a little bit to late for TB 17? Could this land with the
> translations in the next 17.0.x build?

yup it's far far too late for Thunderbird 17 but of course just filing the bug for our next release!
(Assignee)

Comment 3

4 years ago
Created attachment 682766 [details] [diff] [review]
patch

I hope it's okay when also the Lightning change is in this patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #682766 - Flags: review?(bwinton)
(Assignee)

Updated

4 years ago
Attachment #682766 - Attachment is patch: true
Comment on attachment 682766 [details] [diff] [review]
patch

>Bug 812630 - When hovering over the Menu Button, hover text is: "Displays the Application Menu".
>+++ b/mail/locales/en-US/chrome/messenger/messenger.dtd
>-<!ENTITY appmenuButton.tooltip "Displays the Application Menu">
>+<!ENTITY appmenuButton1.tooltip "Display the Thunderbird Menu">

I think we should use "&brandShortName;" here instead of "Thunderbird", but r=me with that change…

(I also like how you changed the tense of the verb from "Displays" to "Display".  Good catch!)

Later,
Blake.
Attachment #682766 - Flags: review?(bwinton) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 683682 [details] [diff] [review]
patch addressing comment

Using now &brandShortName;
On Lightning I had to make some changes and to be sure I'm asking Philipp for review the Lightning side.
Attachment #682766 - Attachment is obsolete: true
Attachment #683682 - Flags: review?(philipp)
Attachment #683682 - Flags: review?(philipp) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5f82efe1e4b1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.