812630 - When hovering over the Menu Button, hover text is: "Displays the Application Menu"

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

IRC :bwinton suggested this hover text is wrong. Perhaps it should be "Display the Thunderbird menu" or some such?

Comment 1

[Richard Marti (:Paenglab)]

Yeah, this would be better.

Isn't this a little bit to late for TB 17? Could this land with the translations in the next 17.0.x build?

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Richard Marti [:Paenglab] from comment #1)
> Yeah, this would be better.
> 
> Isn't this a little bit to late for TB 17? Could this land with the
> translations in the next 17.0.x build?

yup it's far far too late for Thunderbird 17 but of course just filing the bug for our next release!

Comment 3

[Richard Marti (:Paenglab)]

Attachment: patch

I hope it's okay when also the Lightning change is in this patch.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 682766 [details] [diff] [review]
patch

>Bug 812630 - When hovering over the Menu Button, hover text is: "Displays the Application Menu".
>+++ b/mail/locales/en-US/chrome/messenger/messenger.dtd
>-<!ENTITY appmenuButton.tooltip "Displays the Application Menu">
>+<!ENTITY appmenuButton1.tooltip "Display the Thunderbird Menu">

I think we should use "&brandShortName;" here instead of "Thunderbird", but r=me with that change…

(I also like how you changed the tense of the verb from "Displays" to "Display".  Good catch!)

Later,
Blake.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: patch addressing comment

Using now &brandShortName;
On Lightning I had to make some changes and to be sure I'm asking Philipp for review the Lightning side.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/5f82efe1e4b1