Last Comment Bug 812630 - When hovering over the Menu Button, hover text is: "Displays the Application Menu"
: When hovering over the Menu Button, hover text is: "Displays the Application ...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Toolbars and Tabs (show other bugs)
: 17 Branch
: x86_64 Windows 8
: -- normal (vote)
: Thunderbird 20.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-16 13:58 PST by Roland Tanglao :rolandtanglao
Modified: 2012-12-10 05:16 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (5.92 KB, patch)
2012-11-17 08:48 PST, Richard Marti (:Paenglab)
bwinton: review+
Details | Diff | Splinter Review
patch addressing comment (4.71 KB, patch)
2012-11-20 11:03 PST, Richard Marti (:Paenglab)
philipp: review+
Details | Diff | Splinter Review

Description Roland Tanglao :rolandtanglao 2012-11-16 13:58:52 PST
IRC :bwinton suggested this hover text is wrong. Perhaps it should be "Display the Thunderbird menu" or some such?
Comment 1 Richard Marti (:Paenglab) 2012-11-16 14:24:22 PST
Yeah, this would be better.

Isn't this a little bit to late for TB 17? Could this land with the translations in the next 17.0.x build?
Comment 2 Roland Tanglao :rolandtanglao 2012-11-16 14:32:39 PST
(In reply to Richard Marti [:Paenglab] from comment #1)
> Yeah, this would be better.
> 
> Isn't this a little bit to late for TB 17? Could this land with the
> translations in the next 17.0.x build?

yup it's far far too late for Thunderbird 17 but of course just filing the bug for our next release!
Comment 3 Richard Marti (:Paenglab) 2012-11-17 08:48:24 PST
Created attachment 682766 [details] [diff] [review]
patch

I hope it's okay when also the Lightning change is in this patch.
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-11-19 09:55:46 PST
Comment on attachment 682766 [details] [diff] [review]
patch

>Bug 812630 - When hovering over the Menu Button, hover text is: "Displays the Application Menu".
>+++ b/mail/locales/en-US/chrome/messenger/messenger.dtd
>-<!ENTITY appmenuButton.tooltip "Displays the Application Menu">
>+<!ENTITY appmenuButton1.tooltip "Display the Thunderbird Menu">

I think we should use "&brandShortName;" here instead of "Thunderbird", but r=me with that change…

(I also like how you changed the tense of the verb from "Displays" to "Display".  Good catch!)

Later,
Blake.
Comment 5 Richard Marti (:Paenglab) 2012-11-20 11:03:02 PST
Created attachment 683682 [details] [diff] [review]
patch addressing comment

Using now &brandShortName;
On Lightning I had to make some changes and to be sure I'm asking Philipp for review the Lightning side.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-12-10 05:16:36 PST
https://hg.mozilla.org/comm-central/rev/5f82efe1e4b1

Note You need to log in before you can comment on or make changes to this bug.