Closed
Bug 812630
Opened 12 years ago
Closed 11 years ago
When hovering over the Menu Button, hover text is: "Displays the Application Menu"
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 20.0
People
(Reporter: rolandtanglao, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
4.71 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
IRC :bwinton suggested this hover text is wrong. Perhaps it should be "Display the Thunderbird menu" or some such?
Assignee | ||
Comment 1•12 years ago
|
||
Yeah, this would be better. Isn't this a little bit to late for TB 17? Could this land with the translations in the next 17.0.x build?
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Richard Marti [:Paenglab] from comment #1) > Yeah, this would be better. > > Isn't this a little bit to late for TB 17? Could this land with the > translations in the next 17.0.x build? yup it's far far too late for Thunderbird 17 but of course just filing the bug for our next release!
Assignee | ||
Comment 3•12 years ago
|
||
I hope it's okay when also the Lightning change is in this patch.
Assignee | ||
Updated•12 years ago
|
Attachment #682766 -
Attachment is patch: true
Comment 4•12 years ago
|
||
Comment on attachment 682766 [details] [diff] [review] patch >Bug 812630 - When hovering over the Menu Button, hover text is: "Displays the Application Menu". >+++ b/mail/locales/en-US/chrome/messenger/messenger.dtd >-<!ENTITY appmenuButton.tooltip "Displays the Application Menu"> >+<!ENTITY appmenuButton1.tooltip "Display the Thunderbird Menu"> I think we should use "&brandShortName;" here instead of "Thunderbird", but r=me with that change… (I also like how you changed the tense of the verb from "Displays" to "Display". Good catch!) Later, Blake.
Attachment #682766 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Using now &brandShortName; On Lightning I had to make some changes and to be sure I'm asking Philipp for review the Lightning side.
Attachment #682766 -
Attachment is obsolete: true
Attachment #683682 -
Flags: review?(philipp)
Updated•11 years ago
|
Attachment #683682 -
Flags: review?(philipp) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/5f82efe1e4b1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in
before you can comment on or make changes to this bug.
Description
•