812989 - ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Firefox in mozilla-esr17

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Through having forgot to do this on Thunderbird, I realised that these two variables in confvars.sh haven't been updated:

ACCEPTED_MAR_CHANNEL_IDS=firefox-mozilla-beta,firefox-mozilla-release
MAR_CHANNEL_ID=firefox-mozilla-beta

I'm not 100% sure on the effects, but I believe this means that Firefox ESR could mistakenly accept the wrong snippets and get updated to a mainstream based release. Hopefully Brian/Rob can advise here.

Comment 1

[Mark Banner (:standard8)]

Attachment: Proposed fix

I think this is the right thing to do for esr17

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 683049 [details] [diff] [review]
Proposed fix

Review of attachment 683049 [details] [diff] [review]:
-----------------------------------------------------------------

If we will be doing upgrades between ESR_X to ESR_Y, then we should just call this firefox-mozilla-esr

Comment 3

[Brian R. Bondy [:bbondy]]

If we will continue to do updates for ESR10 separate from ESR17 though, then what you have is correct.

Comment 4

[Alex Keybl [:akeybl]]

Attachment: Proposed Patch 2

Comment 5

[Alex Keybl [:akeybl]]

https://hg.mozilla.org/releases/mozilla-esr17/rev/1ba852d4cdee

Comment 6

[Brian R. Bondy [:bbondy]]

ESR17 has had 0 releases done already right? Otherwise this would cause a problem if someone already had the old values.  ESR10 is upgrading to ESR17 right?

Comment 7

[Alex Keybl [:akeybl]]

(In reply to Brian R. Bondy [:bbondy] from comment #6)
> ESR17 has had 0 releases done already right? Otherwise this would cause a
> problem if someone already had the old values.  ESR10 is upgrading to ESR17
> right?

Correct, 0 releases and ESR10 will be upgrading to ESR17 once 17.0.2 is released.

Comment 8

[Brian R. Bondy [:bbondy]]

Perfect, thanks.