Closed Bug 812992 Opened 12 years ago Closed 12 years ago

ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Thunderbird in mozilla-esr17

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
blocker

Tracking

(thunderbird-esr1717+ fixed)

RESOLVED FIXED
Tracking Status
thunderbird-esr17 17+ fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #812989 +++

Through having forgot to do this on Thunderbird, I realised that these two variables in confvars.sh haven't been updated:

ACCEPTED_MAR_CHANNEL_IDS=firefox-mozilla-beta,firefox-mozilla-release
MAR_CHANNEL_ID=firefox-mozilla-beta

I'm not 100% sure on the effects, but I believe this means that Firefox ESR could mistakenly accept the wrong snippets and get updated to a mainstream based release.
Summary: ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Firefox in mozilla-esr17 → ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Thunderbird in mozilla-esr17
Attached patch Proposed fix (obsolete) — Splinter Review
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #683050 - Flags: review?(robert.bugzilla)
Attachment #683050 - Flags: review?(netzen)
Depends on: 796975
Comment on attachment 683050 [details] [diff] [review]
Proposed fix

Review of attachment 683050 [details] [diff] [review]:
-----------------------------------------------------------------

I think ESR10 will be upgraded to ESR17 right? 
If that's not the case this is correct, but if that is the case, we should just call this thunderbird-comm-esr
Attached patch The fixSplinter Review
Ok, for the same reasons as FF in bug 812989, I'm going with this patch.
Attachment #683050 - Attachment is obsolete: true
Attachment #683050 - Flags: review?(robert.bugzilla)
Attachment #683050 - Flags: review?(netzen)
Attachment #683110 - Flags: review+
Attachment #683110 - Flags: approval-comm-esr17+
https://hg.mozilla.org/releases/comm-esr17/rev/e7eb28b251f6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: