ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Thunderbird in mozilla-esr17

RESOLVED FIXED

Status

Thunderbird
Build Config
--
blocker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird-esr1717+ fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #812989 +++

Through having forgot to do this on Thunderbird, I realised that these two variables in confvars.sh haven't been updated:

ACCEPTED_MAR_CHANNEL_IDS=firefox-mozilla-beta,firefox-mozilla-release
MAR_CHANNEL_ID=firefox-mozilla-beta

I'm not 100% sure on the effects, but I believe this means that Firefox ESR could mistakenly accept the wrong snippets and get updated to a mainstream based release.
Summary: ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Firefox in mozilla-esr17 → ACCEPTED_MAR_CHANNEL_IDS and MAR_CHANNEL_ID not updated for Thunderbird in mozilla-esr17
(Assignee)

Comment 1

5 years ago
Created attachment 683050 [details] [diff] [review]
Proposed fix
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #683050 - Flags: review?(robert.bugzilla)
Attachment #683050 - Flags: review?(netzen)
Depends on: 796975
Comment on attachment 683050 [details] [diff] [review]
Proposed fix

Review of attachment 683050 [details] [diff] [review]:
-----------------------------------------------------------------

I think ESR10 will be upgraded to ESR17 right? 
If that's not the case this is correct, but if that is the case, we should just call this thunderbird-comm-esr
(Assignee)

Comment 3

5 years ago
Created attachment 683110 [details] [diff] [review]
The fix

Ok, for the same reasons as FF in bug 812989, I'm going with this patch.
Attachment #683050 - Attachment is obsolete: true
Attachment #683050 - Flags: review?(robert.bugzilla)
Attachment #683050 - Flags: review?(netzen)
Attachment #683110 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #683110 - Flags: approval-comm-esr17+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/releases/comm-esr17/rev/e7eb28b251f6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
This was fixed in esr17.
status-thunderbird-esr17: --- → fixed
tracking-thunderbird-esr17: --- → 17+
You need to log in before you can comment on or make changes to this bug.