813087 - Debugger statement in Scratchpad

Status: RESOLVED WONTFIX

(DevTools Graveyard :: Scratchpad, enhancement, P3)

Description

[Thaddee Tyl [:espadrine]]

Steps to reproduce:

1. Open the Browser Debugger.
2. Open the Scratchpad.
3. Paste the following bit of code in there:
   (function foo(a, b) { var c = a + b; debugger; return c; }(1, 2));
4. Run it.

What I expected:
The Browser Debugger should show the contents of the Scratchpad.

What happens instead:
The Browser Debugger shows the following content for "Scratchpad/1": "Loading…"
It starts debugging. The stacks are displayed correctly. Yet, no JS is displayed.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

This is because scratchpad uses evalInSandbox, passing a dummy Scratchpad/n filename and a line number of 1. We did this to make console.log and friends look intuitive to web developers who don't know about Firefox internals. Perhaps now the Browser Debugger provides a compelling argument for sending the correct source location, and maybe getting the web console to convert "scratchpad.js:330" to "Scratchpad:1" if we think it's important.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Dummy filename removal

Here is a patch to try out. Note that it breaks bug 661762 as it is.

Comment 4

[Rob Campbell [:rc] (:robcee)]

cc'ing Eddy. I think he mentioned taking a look at this during the work week.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Scratchpad was removed in Bug 1519103 (Firefox 72). You can check the alternative in https://wiki.developer.mozilla.org/en-US/docs/Tools/Deprecated_tools#Scratchpad .

The Scratchpad bug list was reviewed and I think this bug can be safely closed.