Last Comment Bug 813295 - Fix entity names for keyboard shortcuts for compose window font size changes after bug 738194
: Fix entity names for keyboard shortcuts for compose window font size changes ...
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 20.0
Assigned To: :aceman
Depends on:
Blocks: 738194
  Show dependency treegraph
Reported: 2012-11-19 13:34 PST by :aceman
Modified: 2012-12-16 16:05 PST (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (5.51 KB, patch)
2012-11-19 13:57 PST, :aceman
neil: review+
l10n: feedback+
Details | Diff | Splinter Review
patch v2 (5.52 KB, patch)
2012-12-14 11:48 PST, :aceman
mkmelin+mozilla: review+
Details | Diff | Splinter Review

Description User image :aceman 2012-11-19 13:34:21 PST
+++ This bug was initially created as a clone of Bug #738194 comment 48 +++

 Gion-Andri Cantieni 2012-11-18 10:59:44 CET

If you change the content of 'decreaseFontSize.key', 'increaseFontSize.key' and 'increaseFontSize.key2' in b/editor/ui/locales/en-US/chrome/composer/editorOverlay.dtd, you should also change the entity names. Otherwise, some localizers won't find this changes.
Comment 1 User image :aceman 2012-11-19 13:57:45 PST
Created attachment 683300 [details] [diff] [review]
Comment 2 User image 2012-11-20 09:07:00 PST
Comment on attachment 683300 [details] [diff] [review]

Hmm, I'm not sure it's ideal to rename the key without the label/accesskey...
Comment 3 User image :aceman 2012-11-20 09:50:16 PST
Yeah, I was not sure about that. But changing those too will produce many additional line changes. I know .label and .accesskey must be changed together, but .key may not be that much linked to them.
Comment 4 User image Mark Banner (:standard8) 2012-11-22 02:47:27 PST
Comment on attachment 683300 [details] [diff] [review]

Axel should know what's best to do here.
Comment 5 User image Axel Hecht [:Pike] 2012-12-14 07:44:33 PST
Comment on attachment 683300 [details] [diff] [review]

Review of attachment 683300 [details] [diff] [review]:

command keys are not associated with labels as accesskeys are, thus you can rename them freely.

sorry for the lag.
Comment 6 User image :aceman 2012-12-14 07:56:41 PST
Thanks Axel.

Comment 7 User image 2012-12-14 08:20:17 PST
Comment on attachment 683300 [details] [diff] [review]

>     <key id="removestyleskb"       key="&formatRemoveStyles.key;"   observes="cmd_removeStyles"  modifiers="accel, shift"/>
>     <key id="removestyleskb2"      key=" "   observes="cmd_removeStyles"  modifiers="accel"/>
>     <key id="removelinkskb"        key="&formatRemoveLinks.key;"    observes="cmd_removeLinks"  modifiers="accel, shift"/>
>     <key id="removenamedanchorskb" key="&formatRemoveNamedAnchors2.key;"    observes="cmd_removeNamedAnchors"  modifiers="accel, shift"/>
>+    <key id="decreasefontsizekb"   key="&decrementFontSize.key;"     observes="cmd_decreaseFont"  modifiers="accel"/>
>+    <key                           key="&decrementFontSize.key;"     observes="cmd_decreaseFont"  modifiers="accel, shift"/>
>+    <key                           key="&decrementFontSize.key2;"    observes="cmd_decreaseFont"  modifiers="accel"/>
>+    <key id="increasefontsizekb"   key="&incrementFontSize.key;"     observes="cmd_increaseFont"  modifiers="accel"/>
>+    <key                           key="&incrementFontSize.key;"     observes="cmd_increaseFont"  modifiers="accel, shift"/>
>+    <key                           key="&incrementFontSize.key2;"    observes="cmd_increaseFont"  modifiers="accel"/>
>     <key id="insertlinkkb"         key="&insertLinkCmd.key;"           observes="cmd_link"          modifiers="accel"/>
[You might want to keep the observes and modifiers attributes lined up.]
Comment 8 User image :aceman 2012-12-14 11:48:14 PST
Created attachment 692409 [details] [diff] [review]
patch v2
Comment 9 User image Ryan VanderMeulen [:RyanVM] 2012-12-16 16:05:15 PST

Note You need to log in before you can comment on or make changes to this bug.