813295 - Fix entity names for keyboard shortcuts for compose window font size changes after bug 738194

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #738194 comment 48 +++

 Gion-Andri Cantieni 2012-11-18 10:59:44 CET

If you change the content of 'decreaseFontSize.key', 'increaseFontSize.key' and 'increaseFontSize.key2' in b/editor/ui/locales/en-US/chrome/composer/editorOverlay.dtd, you should also change the entity names. Otherwise, some localizers won't find this changes.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 683300 [details] [diff] [review]
patch

Hmm, I'm not sure it's ideal to rename the key without the label/accesskey...

Comment 3

[:aceman]

Yeah, I was not sure about that. But changing those too will produce many additional line changes. I know .label and .accesskey must be changed together, but .key may not be that much linked to them.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 683300 [details] [diff] [review]
patch

Axel should know what's best to do here.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 683300 [details] [diff] [review]
patch

Review of attachment 683300 [details] [diff] [review]:
-----------------------------------------------------------------

command keys are not associated with labels as accesskeys are, thus you can rename them freely.

sorry for the lag.

Comment 6

[:aceman]

Thanks Axel.

Neil?

Comment 7

[[e-mail]]

Comment on attachment 683300 [details] [diff] [review]
patch

>     <key id="removestyleskb"       key="&formatRemoveStyles.key;"   observes="cmd_removeStyles"  modifiers="accel, shift"/>
>     <key id="removestyleskb2"      key=" "   observes="cmd_removeStyles"  modifiers="accel"/>
>     <key id="removelinkskb"        key="&formatRemoveLinks.key;"    observes="cmd_removeLinks"  modifiers="accel, shift"/>
>     <key id="removenamedanchorskb" key="&formatRemoveNamedAnchors2.key;"    observes="cmd_removeNamedAnchors"  modifiers="accel, shift"/>
>+    <key id="decreasefontsizekb"   key="&decrementFontSize.key;"     observes="cmd_decreaseFont"  modifiers="accel"/>
>+    <key                           key="&decrementFontSize.key;"     observes="cmd_decreaseFont"  modifiers="accel, shift"/>
>+    <key                           key="&decrementFontSize.key2;"    observes="cmd_decreaseFont"  modifiers="accel"/>
> 
>+    <key id="increasefontsizekb"   key="&incrementFontSize.key;"     observes="cmd_increaseFont"  modifiers="accel"/>
>+    <key                           key="&incrementFontSize.key;"     observes="cmd_increaseFont"  modifiers="accel, shift"/>
>+    <key                           key="&incrementFontSize.key2;"    observes="cmd_increaseFont"  modifiers="accel"/>
> 
>     <key id="insertlinkkb"         key="&insertLinkCmd.key;"           observes="cmd_link"          modifiers="accel"/>
[You might want to keep the observes and modifiers attributes lined up.]

Comment 8

[:aceman]

Attachment: patch v2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/8ff810e42d87