Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix entity names for keyboard shortcuts for compose window font size changes after bug 738194

RESOLVED FIXED in Thunderbird 20.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 20.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.52 KB, patch
Magnus Melin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #738194 comment 48 +++

 Gion-Andri Cantieni 2012-11-18 10:59:44 CET

If you change the content of 'decreaseFontSize.key', 'increaseFontSize.key' and 'increaseFontSize.key2' in b/editor/ui/locales/en-US/chrome/composer/editorOverlay.dtd, you should also change the entity names. Otherwise, some localizers won't find this changes.
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 683300 [details] [diff] [review]
patch
Attachment #683300 - Flags: review?(neil)

Comment 2

5 years ago
Comment on attachment 683300 [details] [diff] [review]
patch

Hmm, I'm not sure it's ideal to rename the key without the label/accesskey...
(Assignee)

Comment 3

5 years ago
Yeah, I was not sure about that. But changing those too will produce many additional line changes. I know .label and .accesskey must be changed together, but .key may not be that much linked to them.
Comment on attachment 683300 [details] [diff] [review]
patch

Axel should know what's best to do here.
Attachment #683300 - Flags: feedback?(l10n)

Comment 5

5 years ago
Comment on attachment 683300 [details] [diff] [review]
patch

Review of attachment 683300 [details] [diff] [review]:
-----------------------------------------------------------------

command keys are not associated with labels as accesskeys are, thus you can rename them freely.

sorry for the lag.
Attachment #683300 - Flags: feedback?(l10n) → feedback+
(Assignee)

Comment 6

5 years ago
Thanks Axel.

Neil?
Flags: needinfo?(neil)

Updated

5 years ago
Attachment #683300 - Flags: review?(neil) → review+

Comment 7

5 years ago
Comment on attachment 683300 [details] [diff] [review]
patch

>     <key id="removestyleskb"       key="&formatRemoveStyles.key;"   observes="cmd_removeStyles"  modifiers="accel, shift"/>
>     <key id="removestyleskb2"      key=" "   observes="cmd_removeStyles"  modifiers="accel"/>
>     <key id="removelinkskb"        key="&formatRemoveLinks.key;"    observes="cmd_removeLinks"  modifiers="accel, shift"/>
>     <key id="removenamedanchorskb" key="&formatRemoveNamedAnchors2.key;"    observes="cmd_removeNamedAnchors"  modifiers="accel, shift"/>
>+    <key id="decreasefontsizekb"   key="&decrementFontSize.key;"     observes="cmd_decreaseFont"  modifiers="accel"/>
>+    <key                           key="&decrementFontSize.key;"     observes="cmd_decreaseFont"  modifiers="accel, shift"/>
>+    <key                           key="&decrementFontSize.key2;"    observes="cmd_decreaseFont"  modifiers="accel"/>
> 
>+    <key id="increasefontsizekb"   key="&incrementFontSize.key;"     observes="cmd_increaseFont"  modifiers="accel"/>
>+    <key                           key="&incrementFontSize.key;"     observes="cmd_increaseFont"  modifiers="accel, shift"/>
>+    <key                           key="&incrementFontSize.key2;"    observes="cmd_increaseFont"  modifiers="accel"/>
> 
>     <key id="insertlinkkb"         key="&insertLinkCmd.key;"           observes="cmd_link"          modifiers="accel"/>
[You might want to keep the observes and modifiers attributes lined up.]
Flags: needinfo?(neil)
(Assignee)

Comment 8

5 years ago
Created attachment 692409 [details] [diff] [review]
patch v2
Attachment #683300 - Attachment is obsolete: true
Attachment #692409 - Flags: review?(mkmelin+mozilla)

Updated

5 years ago
Attachment #692409 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8ff810e42d87
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.