813316 - [OS X] User menu item appears blank at top of social provider tools menu

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Matthew N. [:MattN]]

Attachment: Screenshot of blank menu item at top

On OS X Nightly there seems to be an empty menu item at the beginning of the Facebook submenu.

Not reproducible on Windows.

Comment 1

[Matthew N. [:MattN]]

It's the user's name and profile picture that is missing on OS X.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Regression from bug 805217, presumably?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> Regression from bug 805217, presumably?

Yeah. Turns out the Mac popup menu supports CSS styling (when opened from the toolbar button), but the menu that opens from the native top menu row doesn't, so we'll have to use a standard label and icon there. I've got a patch almost ready for that, just need to compile and see if it works :)

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Since the menuitem needs the two properties (image/label), I merged the broadcasters into one. The other elements will inherit some unused properties but that's ok

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 683379 [details] [diff] [review]
Patch

Review of attachment 683379 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for putting together a fix for this so quickly.

::: browser/base/content/browser-menubar.inc
@@ +506,5 @@
>                          key="key_openAddons"
>                          command="Tools:Addons"/>
>                <menu id="menu_socialAmbientMenu">
>                  <menupopup id="menu_social-statusarea-popup">
> +                  <menuitem class="social-statusarea-user menuitem-iconic" pack="start" align="center" observes="socialBroadcaster_userPortrait"

nit: can you put the observes="..." on its own line?

::: browser/base/content/browser-sets.inc
@@ +251,5 @@
>                   label="&getMoreDevtoolsCmd.label;"
>                   oncommand="openUILinkIn('https://addons.mozilla.org/firefox/collections/mozilla/webdeveloper/', 'tab');"/>
>  
>      <!-- SocialAPI broadcasters -->
> +    <broadcaster id="socialBroadcaster_userPortrait"

This should be renamed since it is no longer only about the user portrait. Maybe socialBroadcaster_userDetails ?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7d66a7e1e2

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Attachment: Screenshot

Screenshot of the fix showing how the user portrait icon is displayed as 16x16 there. It still shows as 32x32 on the menu that pops up from the toolbar button

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fe7d66a7e1e2

Comment 9

[Matthew N. [:MattN]]

My profile picture and name now show in the menu item

20.0a1 (2012-11-21)

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 683379 [details] [diff] [review]
Patch

Bug 805217 landed on 19, and this fix landed on m-c for 20, so we need to uplift this one for aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 805217
User impact if declined: Blank menu entry on Mac native menu
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): very small, limited to social menuitems
String or UUID changes made by this patch: none

Comment 11

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f0380e240ca

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Working on FF 19 beta 5.
User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130206083616